Skip to content

Commit be50440

Browse files
Alice YangAndroid (Google) Code Review
authored andcommitted
Merge "Fix bug where existing account not pre-checked" into jb-dev
2 parents 69a1f6e + 6cab5e8 commit be50440

File tree

1 file changed

+8
-16
lines changed

1 file changed

+8
-16
lines changed

core/java/android/accounts/ChooseTypeAndAccountActivity.java

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import android.text.TextUtils;
2323
import android.util.Log;
2424
import android.view.View;
25-
import android.view.ViewGroup;
2625
import android.widget.AdapterView;
2726
import android.widget.ArrayAdapter;
2827
import android.widget.Button;
@@ -280,23 +279,16 @@ public void onItemClick(AdapterView<?> parent, View v, int position, long id) {
280279
if (selectedAddNewAccount) {
281280
mSelectedItemIndex = mAccounts.size();
282281
}
283-
if (Log.isLoggable(TAG, Log.VERBOSE)) {
284-
Log.v(TAG, "mSelectedItemIndex is " + mSelectedItemIndex);
285-
}
286-
287-
ViewGroup buttonBar = (ViewGroup) findViewById(R.id.button_bar);
288-
if (buttonBar != null) {
289-
mOkButton = (Button) buttonBar.findViewById(android.R.id.button2);
290-
if (mSelectedItemIndex != SELECTED_ITEM_NONE) {
291-
// If caller specified a selectedAccount, then display that as selected and enable
292-
// the "OK" button by default.
293-
list.setSelection(mSelectedItemIndex);
294-
mOkButton.setEnabled(true);
295-
} else {
296-
// Otherwise "OK" button is disabled since nothing is pre-selected.
297-
mOkButton.setEnabled(false);
282+
if (mSelectedItemIndex != SELECTED_ITEM_NONE) {
283+
list.setItemChecked(mSelectedItemIndex, true);
284+
if (Log.isLoggable(TAG, Log.VERBOSE)) {
285+
Log.v(TAG, "List item " + mSelectedItemIndex + " should be selected");
298286
}
299287
}
288+
289+
// Only enable "OK" button if something has been selected.
290+
mOkButton = (Button) findViewById(android.R.id.button2);
291+
mOkButton.setEnabled(mSelectedItemIndex != SELECTED_ITEM_NONE);
300292
}
301293

302294
@Override

0 commit comments

Comments
 (0)