Skip to content

Commit bc0edec

Browse files
jsharkeyAndroid (Google) Code Review
authored andcommitted
Merge "Increase readability of connectivity event log." into jb-mr1.1-dev
2 parents f6f47e9 + 2528b50 commit bc0edec

File tree

2 files changed

+4
-18
lines changed

2 files changed

+4
-18
lines changed

services/java/com/android/server/ConnectivityService.java

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2686,18 +2686,8 @@ public void handleMessage(Message msg) {
26862686
state + "/" + info.getDetailedState());
26872687
}
26882688

2689-
// Connectivity state changed:
2690-
// [31-14] Reserved for future use
2691-
// [13-10] Network subtype (for mobile network, as defined
2692-
// by TelephonyManager)
2693-
// [9-4] Detailed state ordinal (as defined by
2694-
// NetworkInfo.DetailedState)
2695-
// [3-0] Network type (as defined by ConnectivityManager)
2696-
int eventLogParam = (info.getType() & 0xf) |
2697-
((info.getDetailedState().ordinal() & 0x3f) << 4) |
2698-
(info.getSubtype() << 10);
2699-
EventLog.writeEvent(EventLogTags.CONNECTIVITY_STATE_CHANGED,
2700-
eventLogParam);
2689+
EventLogTags.writeConnectivityStateChanged(
2690+
info.getType(), info.getSubtype(), info.getDetailedState().ordinal());
27012691

27022692
if (info.getDetailedState() ==
27032693
NetworkInfo.DetailedState.FAILED) {

services/java/com/android/server/EventLogTags.logtags

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -135,12 +135,8 @@ option java_package com.android.server
135135
# ---------------------------
136136
# ConnectivityService.java
137137
# ---------------------------
138-
# Connectivity state changed:
139-
# [31-14] Reserved for future use
140-
# [13-10] Network subtype (for mobile network, as defined by TelephonyManager)
141-
# [ 9- 4] Detailed state ordinal (as defined by NetworkInfo.DetailedState)
142-
# [ 3- 0] Network type (as defined by ConnectivityManager)
143-
50020 connectivity_state_changed (custom|1|5)
138+
# Connectivity state changed
139+
50020 connectivity_state_changed (type|1),(subtype|1),(state|1)
144140

145141

146142
# ---------------------------

0 commit comments

Comments
 (0)