Skip to content

Commit b8021a8

Browse files
Fabrice Di MeglioAndroid (Google) Code Review
authored andcommitted
Merge "Fix bug #7326778 Rename LayoutParams.onResolveLayoutDirection(int)" into jb-mr1-dev
2 parents 02f0daa + 2918ab6 commit b8021a8

File tree

6 files changed

+12
-12
lines changed

6 files changed

+12
-12
lines changed

api/17.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25677,7 +25677,7 @@ package android.view {
2567725677
ctor public ViewGroup.LayoutParams(android.content.Context, android.util.AttributeSet);
2567825678
ctor public ViewGroup.LayoutParams(int, int);
2567925679
ctor public ViewGroup.LayoutParams(android.view.ViewGroup.LayoutParams);
25680-
method public void onResolveLayoutDirection(int);
25680+
method public void resolveLayoutDirection(int);
2568125681
method protected void setBaseAttributes(android.content.res.TypedArray, int, int);
2568225682
field public static final deprecated int FILL_PARENT = -1; // 0xffffffff
2568325683
field public static final int MATCH_PARENT = -1; // 0xffffffff

api/current.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25677,7 +25677,7 @@ package android.view {
2567725677
ctor public ViewGroup.LayoutParams(android.content.Context, android.util.AttributeSet);
2567825678
ctor public ViewGroup.LayoutParams(int, int);
2567925679
ctor public ViewGroup.LayoutParams(android.view.ViewGroup.LayoutParams);
25680-
method public void onResolveLayoutDirection(int);
25680+
method public void resolveLayoutDirection(int);
2568125681
method protected void setBaseAttributes(android.content.res.TypedArray, int, int);
2568225682
field public static final deprecated int FILL_PARENT = -1; // 0xffffffff
2568325683
field public static final int MATCH_PARENT = -1; // 0xffffffff

core/java/android/view/View.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10000,7 +10000,7 @@ public void setLayoutParams(ViewGroup.LayoutParams params) {
1000010000
*/
1000110001
private void resolveLayoutParams() {
1000210002
if (mLayoutParams != null) {
10003-
mLayoutParams.onResolveLayoutDirection(getLayoutDirection());
10003+
mLayoutParams.resolveLayoutDirection(getLayoutDirection());
1000410004
}
1000510005
}
1000610006

core/java/android/view/ViewGroup.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5542,7 +5542,7 @@ protected void setBaseAttributes(TypedArray a, int widthAttr, int heightAttr) {
55425542
* {@link View#LAYOUT_DIRECTION_LTR}
55435543
* {@link View#LAYOUT_DIRECTION_RTL}
55445544
*/
5545-
public void onResolveLayoutDirection(int layoutDirection) {
5545+
public void resolveLayoutDirection(int layoutDirection) {
55465546
}
55475547

55485548
/**
@@ -5886,7 +5886,7 @@ public int getLayoutDirection() {
58865886
* may be overridden depending on layout direction.
58875887
*/
58885888
@Override
5889-
public void onResolveLayoutDirection(int layoutDirection) {
5889+
public void resolveLayoutDirection(int layoutDirection) {
58905890
setLayoutDirection(layoutDirection);
58915891

58925892
if (!isMarginRelative()) return;

core/java/android/widget/RelativeLayout.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -729,7 +729,7 @@ private boolean positionChildHorizontal(View child, LayoutParams params, int myW
729729

730730
final int layoutDirection = getLayoutDirection();
731731
int[] rules = params.getRules(layoutDirection);
732-
params.onResolveLayoutDirection(layoutDirection);
732+
params.resolveLayoutDirection(layoutDirection);
733733

734734
if (params.mLeft < 0 && params.mRight >= 0) {
735735
// Right is fixed, but left varies
@@ -983,7 +983,7 @@ protected void onLayout(boolean changed, int l, int t, int r, int b) {
983983
if (child.getVisibility() != GONE) {
984984
RelativeLayout.LayoutParams st =
985985
(RelativeLayout.LayoutParams) child.getLayoutParams();
986-
st.onResolveLayoutDirection(getLayoutDirection());
986+
st.resolveLayoutDirection(getLayoutDirection());
987987
child.layout(st.mLeft, st.mTop, st.mRight, st.mBottom);
988988
}
989989
}
@@ -1393,7 +1393,7 @@ public int[] getRules() {
13931393
}
13941394

13951395
@Override
1396-
public void onResolveLayoutDirection(int layoutDirection) {
1396+
public void resolveLayoutDirection(int layoutDirection) {
13971397
final boolean isLayoutRtl = isLayoutRtl();
13981398
if (isLayoutRtl) {
13991399
if (mStart != DEFAULT_RELATIVE) mRight = mStart;
@@ -1407,7 +1407,7 @@ public void onResolveLayoutDirection(int layoutDirection) {
14071407
resolveRules(layoutDirection);
14081408
}
14091409
// This will set the layout direction
1410-
super.onResolveLayoutDirection(layoutDirection);
1410+
super.resolveLayoutDirection(layoutDirection);
14111411
}
14121412
}
14131413

core/java/com/android/internal/widget/ActionBarView.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1098,7 +1098,7 @@ protected void onLayout(boolean changed, int l, int t, int r, int b) {
10981098
if (customView != null) {
10991099
final int resolvedLayoutDirection = getLayoutDirection();
11001100
ViewGroup.LayoutParams lp = customView.getLayoutParams();
1101-
lp.onResolveLayoutDirection(resolvedLayoutDirection);
1101+
lp.resolveLayoutDirection(resolvedLayoutDirection);
11021102
final ActionBar.LayoutParams ablp = lp instanceof ActionBar.LayoutParams ?
11031103
(ActionBar.LayoutParams) lp : null;
11041104
final int gravity = ablp != null ? ablp.gravity : DEFAULT_CUSTOM_GRAVITY;
@@ -1385,7 +1385,7 @@ protected void onLayout(boolean changed, int l, int t, int r, int b) {
13851385
int upOffset = 0;
13861386
if (mUpView.getVisibility() != GONE) {
13871387
final LayoutParams upLp = (LayoutParams) mUpView.getLayoutParams();
1388-
upLp.onResolveLayoutDirection(layoutDirection);
1388+
upLp.resolveLayoutDirection(layoutDirection);
13891389
final int upHeight = mUpView.getMeasuredHeight();
13901390
final int upWidth = mUpView.getMeasuredWidth();
13911391
upOffset = upLp.leftMargin + upWidth + upLp.rightMargin;
@@ -1406,7 +1406,7 @@ protected void onLayout(boolean changed, int l, int t, int r, int b) {
14061406
}
14071407

14081408
final LayoutParams iconLp = (LayoutParams) mIconView.getLayoutParams();
1409-
iconLp.onResolveLayoutDirection(layoutDirection);
1409+
iconLp.resolveLayoutDirection(layoutDirection);
14101410
final int iconHeight = mIconView.getMeasuredHeight();
14111411
final int iconWidth = mIconView.getMeasuredWidth();
14121412
final int hCenter = (r - l) / 2;

0 commit comments

Comments
 (0)