Skip to content

Commit b260f35

Browse files
Romain GuyAndroid (Google) Code Review
authored andcommitted
Merge "Catch padding changes in ViewGroup to properly clip children Bug #6886339" into jb-mr1-dev
2 parents b0e0c1c + 2440e67 commit b260f35

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

core/java/android/view/View.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14107,7 +14107,7 @@ public void setPadding(int left, int top, int right, int bottom) {
1410714107
internalSetPadding(left, top, right, bottom);
1410814108
}
1410914109

14110-
private void internalSetPadding(int left, int top, int right, int bottom) {
14110+
void internalSetPadding(int left, int top, int right, int bottom) {
1411114111
mUserPaddingLeft = left;
1411214112
mUserPaddingRight = right;
1411314113
mUserPaddingBottom = bottom;

core/java/android/view/ViewGroup.java

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,14 @@ public abstract class ViewGroup extends View implements ViewParent, ViewManager
170170
* This field should be made private, so it is hidden from the SDK.
171171
* {@hide}
172172
*/
173+
@ViewDebug.ExportedProperty(flagMapping = {
174+
@ViewDebug.FlagToString(mask = FLAG_CLIP_CHILDREN, equals = FLAG_CLIP_CHILDREN,
175+
name = "CLIP_CHILDREN"),
176+
@ViewDebug.FlagToString(mask = FLAG_CLIP_TO_PADDING, equals = FLAG_CLIP_TO_PADDING,
177+
name = "CLIP_TO_PADDING"),
178+
@ViewDebug.FlagToString(mask = FLAG_PADDING_NOT_NULL, equals = FLAG_PADDING_NOT_NULL,
179+
name = "PADDING_NOT_NULL")
180+
})
173181
protected int mGroupFlags;
174182

175183
/*
@@ -2509,12 +2517,9 @@ void dispatchDetachedFromWindow() {
25092517
super.dispatchDetachedFromWindow();
25102518
}
25112519

2512-
/**
2513-
* {@inheritDoc}
2514-
*/
25152520
@Override
2516-
public void setPadding(int left, int top, int right, int bottom) {
2517-
super.setPadding(left, top, right, bottom);
2521+
void internalSetPadding(int left, int top, int right, int bottom) {
2522+
super.internalSetPadding(left, top, right, bottom);
25182523

25192524
if ((mPaddingLeft | mPaddingTop | mPaddingRight | mPaddingBottom) != 0) {
25202525
mGroupFlags |= FLAG_PADDING_NOT_NULL;

0 commit comments

Comments
 (0)