Sanity check network stats coming from disk.

jsharkey · jsharkey · commit b0a579f83369 · 2012-11-02T15:38:15.000-07:00
Throw early when structure is unstable, which allows the normal
recoverFromWtf() path to recover automatically.

Bug: 7440485
Change-Id: Ic150d17daac4de7c9ff3489025403a9b485b4620
diff --git a/core/java/android/net/NetworkStatsHistory.java b/core/java/android/net/NetworkStatsHistory.java
@@ -177,6 +177,12 @@ public NetworkStatsHistory(DataInputStream in) throws IOException {
                 throw new ProtocolException("unexpected version: " + version);
             }
         }
+
+        if (bucketStart.length != bucketCount || rxBytes.length != bucketCount
+                || rxPackets.length != bucketCount || txBytes.length != bucketCount
+                || txPackets.length != bucketCount || operations.length != bucketCount) {
+            throw new ProtocolException("Mismatched history lengths");
+        }
     }
 
     public void writeToStream(DataOutputStream out) throws IOException {

Original file line number	Diff line number	Diff line change
`@@ -177,6 +177,12 @@ public NetworkStatsHistory(DataInputStream in) throws IOException {`
`177`	`177`	`throw new ProtocolException("unexpected version: " + version);`
`178`	`178`	`}`
`179`	`179`	`}`
	`180`	`+`
	`181`	`+ if (bucketStart.length != bucketCount \|\| rxBytes.length != bucketCount`
	`182`	`+ \|\| rxPackets.length != bucketCount \|\| txBytes.length != bucketCount`
	`183`	`+ \|\| txPackets.length != bucketCount \|\| operations.length != bucketCount) {`
	`184`	`+ throw new ProtocolException("Mismatched history lengths");`
	`185`	`+ }`
`180`	`186`	`}`
`181`	`187`
`182`	`188`	`public void writeToStream(DataOutputStream out) throws IOException {`