AbsListView does not populate accessibility events correctly.

sganov · sganov · commit aa56534722a4 · 2011-09-05T16:41:51.000-07:00
The toIndex of accessibility events fired from a AbsListView
is exclusive but should be inclusive i.e. it was reported one
more that it has to be.

bug:5256286

Change-Id: I496959fdfb6760b0c74899730c4cc558e89234a6
diff --git a/core/java/android/widget/AdapterView.java b/core/java/android/widget/AdapterView.java
@@ -926,8 +926,10 @@ public void onInitializeAccessibilityEvent(AccessibilityEvent event) {
         }
         event.setItemCount(getCount());
         event.setCurrentItemIndex(getSelectedItemPosition());
-        event.setFromIndex(mFirstPosition);
-        event.setToIndex(mFirstPosition + getChildCount());
+        if (getChildCount() > 0) {
+            event.setFromIndex(getFirstVisiblePosition());
+            event.setToIndex(getLastVisiblePosition());
+        }
     }
 
     @Override

Original file line number	Diff line number	Diff line change
`@@ -926,8 +926,10 @@ public void onInitializeAccessibilityEvent(AccessibilityEvent event) {`
`926`	`926`	`}`
`927`	`927`	`event.setItemCount(getCount());`
`928`	`928`	`event.setCurrentItemIndex(getSelectedItemPosition());`
`929`		`- event.setFromIndex(mFirstPosition);`
`930`		`- event.setToIndex(mFirstPosition + getChildCount());`
	`929`	`+ if (getChildCount() > 0) {`
	`930`	`+ event.setFromIndex(getFirstVisiblePosition());`
	`931`	`+ event.setToIndex(getLastVisiblePosition());`
	`932`	`+ }`
`931`	`933`	`}`
`932`	`934`
`933`	`935`	`@Override`