Skip to content

Commit a90e451

Browse files
committed
Calling the correct method when adding accessibility focusables.
1. Since we added explicit accessibility focusable attribute when adding focusables views that do so should call this method. Some views were not updated to do so. bug:6581924 Change-Id: Id64c0b2d76e5269ebf3fbe17203e73b174bdb843
1 parent 01827ce commit a90e451

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

core/java/android/view/View.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6308,10 +6308,7 @@ private void requestAccessibilityFocusFromHover() {
63086308
}
63096309
}
63106310

6311-
/**
6312-
* @hide
6313-
*/
6314-
public boolean canTakeAccessibilityFocusFromHover() {
6311+
private boolean canTakeAccessibilityFocusFromHover() {
63156312
if (includeForAccessibility() && isActionableForAccessibility()) {
63166313
return true;
63176314
}

core/java/android/widget/AbsListView.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1334,12 +1334,12 @@ public void addFocusables(ArrayList<View> views, int direction, int focusableMod
13341334
switch(direction) {
13351335
case ACCESSIBILITY_FOCUS_BACKWARD: {
13361336
View focusable = (getChildCount() > 0) ? getChildAt(getChildCount() - 1) : this;
1337-
if (focusable.canTakeAccessibilityFocusFromHover()) {
1337+
if (focusable.isAccessibilityFocusable()) {
13381338
views.add(focusable);
13391339
}
13401340
} return;
13411341
case ACCESSIBILITY_FOCUS_FORWARD: {
1342-
if (canTakeAccessibilityFocusFromHover()) {
1342+
if (isAccessibilityFocusable()) {
13431343
views.add(this);
13441344
}
13451345
} return;

core/java/android/widget/NumberPicker.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1421,7 +1421,7 @@ public void addFocusables(ArrayList<View> views, int direction, int focusableMod
14211421
// We do not want the real descendant to be considered focus search
14221422
// since it is managed by the accessibility node provider.
14231423
if ((focusableMode & FOCUSABLES_ACCESSIBILITY) == FOCUSABLES_ACCESSIBILITY) {
1424-
if (canTakeAccessibilityFocusFromHover() || getAccessibilityNodeProvider() != null) {
1424+
if (isAccessibilityFocusable()) {
14251425
views.add(this);
14261426
return;
14271427
}

0 commit comments

Comments
 (0)