Skip to content

Commit a85236e

Browse files
committed
Accessibility focus should not scroll automatically.
1. We use auto scroll when a view gets accessibility focus. Pros: Having magnification and TalkBack enabled together (not a common use case) will have the accessibility focused view on the screen (it is auto panned). Cons: A blind user can get stuck in a very lock scroll view - not good. 2. We do not auto scroll when a view gets accessibility focus. Pros: A blind user cannot get stuck in a long scroll view as he has to explicitly scroll. Cons: The magnified area will not pan to ensure the accessibility focused view is visible. Option one is the better trade off and this change removes the auto scrolling. bug:7265773 Change-Id: I209b54ed18acad36c1f35b4c09b980e45ec9bbff
1 parent 57e6203 commit a85236e

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

core/java/android/view/View.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6466,11 +6466,6 @@ public boolean requestAccessibilityFocus() {
64666466
if (viewRootImpl != null) {
64676467
viewRootImpl.setAccessibilityFocus(this, null);
64686468
}
6469-
if (mAttachInfo != null) {
6470-
Rect rectangle = mAttachInfo.mTmpInvalRect;
6471-
getDrawingRect(rectangle);
6472-
requestRectangleOnScreen(rectangle);
6473-
}
64746469
invalidate();
64756470
sendAccessibilityEvent(AccessibilityEvent.TYPE_VIEW_ACCESSIBILITY_FOCUSED);
64766471
notifyAccessibilityStateChanged();

0 commit comments

Comments
 (0)