Skip to content

Commit a7da8af

Browse files
author
Jim Miller
committed
Fix 6693743: update animation ring for keyguard and search panel
This is a partial revert of change Ibce96f45eb6a94582c694108b99e243fd57b1955. This change: - shows the expanding ring animation on keyguard and navbar search - disables the first ping wave animation on both. - restores the outer ring Change-Id: I429d23a49ca2868dc00872b8b8fde000d6a53a6d
1 parent c258546 commit a7da8af

File tree

7 files changed

+8
-13
lines changed

7 files changed

+8
-13
lines changed

core/java/com/android/internal/widget/multiwaveview/GlowPadView.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,6 @@ private void switchToState(int state, float x, float y) {
361361
mHandleDrawable.setAlpha(0.0f);
362362
deactivateTargets();
363363
showTargets(true);
364-
ping();
365364
startBackgroundAnimation(INITIAL_SHOW_HANDLE_DURATION, 1.0f);
366365
setGrabbedState(OnTriggerListener.CENTER_HANDLE);
367366
if (AccessibilityManager.getInstance(mContext).isEnabled()) {
@@ -485,11 +484,7 @@ private void hideTargets(boolean animate, boolean expanded) {
485484
final int duration = animate ? HIDE_ANIMATION_DURATION : 0;
486485
final int delay = animate ? HIDE_ANIMATION_DELAY : 0;
487486

488-
// TODO: add an attribute for this. For now we'll show the expand for navbar, but not
489-
// keyguard.
490-
final boolean expandDisabled = !mAlwaysTrackFinger;
491-
492-
final float targetScale = (expanded || expandDisabled) ?
487+
final float targetScale = expanded ?
493488
TARGET_SCALE_EXPANDED : TARGET_SCALE_COLLAPSED;
494489
final int length = mTargetDrawables.size();
495490
final TimeInterpolator interpolator = Ease.Cubic.easeOut;
@@ -505,7 +500,7 @@ private void hideTargets(boolean animate, boolean expanded) {
505500
"onUpdate", mUpdateListener));
506501
}
507502

508-
final float ringScaleTarget = (expanded || expandDisabled) ?
503+
final float ringScaleTarget = expanded ?
509504
RING_SCALE_EXPANDED : RING_SCALE_COLLAPSED;
510505
mTargetAnimations.add(Tweener.to(mOuterRing, duration,
511506
"ease", interpolator,

core/res/res/drawable/ic_lockscreen_outerring.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,5 @@
2020
<size android:height="@dimen/keyguard_lockscreen_outerring_diameter"
2121
android:width="@dimen/keyguard_lockscreen_outerring_diameter" />
2222
<solid android:color="#00000000" />
23-
<stroke android:color="#00000000" android:width="2dp" />
23+
<stroke android:color="#1affffff" android:width="2dp" />
2424
</shape>

packages/SystemUI/res/drawable/navbar_search_outerring.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,5 @@
1919
<size android:height="@dimen/navbar_search_outerring_diameter"
2020
android:width="@dimen/navbar_search_outerring_diameter" />
2121
<solid android:color="#00000000" />
22-
<stroke android:color="#00000000" android:width="2dp" />
22+
<stroke android:color="#40ffffff" android:width="2dp" />
2323
</shape>

packages/SystemUI/res/layout-land/status_bar_search_panel.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
prvandroid:outerRadius="@dimen/navbar_search_outerring_radius"
5555
prvandroid:innerRadius="@*android:dimen/glowpadview_inner_radius"
5656
prvandroid:snapMargin="@dimen/navbar_search_snap_margin"
57-
prvandroid:feedbackCount="1"
57+
prvandroid:feedbackCount="0"
5858
prvandroid:vibrationDuration="@integer/config_vibration_duration"
5959
prvandroid:alwaysTrackFinger="true"
6060
prvandroid:glowRadius="@*android:dimen/glowpadview_glow_radius"

packages/SystemUI/res/layout-port/status_bar_search_panel.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
prvandroid:outerRadius="@dimen/navbar_search_outerring_radius"
5555
prvandroid:innerRadius="@*android:dimen/glowpadview_inner_radius"
5656
prvandroid:snapMargin="@dimen/navbar_search_snap_margin"
57-
prvandroid:feedbackCount="1"
57+
prvandroid:feedbackCount="0"
5858
prvandroid:vibrationDuration="@integer/config_vibration_duration"
5959
prvandroid:alwaysTrackFinger="true"
6060
prvandroid:glowRadius="@*android:dimen/glowpadview_glow_radius"

packages/SystemUI/res/layout-sw600dp/status_bar_search_panel.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
prvandroid:outerRadius="@dimen/navbar_search_outerring_radius"
4141
prvandroid:innerRadius="@*android:dimen/glowpadview_inner_radius"
4242
prvandroid:snapMargin="@dimen/navbar_search_snap_margin"
43-
prvandroid:feedbackCount="1"
43+
prvandroid:feedbackCount="0"
4444
prvandroid:vibrationDuration="@integer/config_vibration_duration"
4545
prvandroid:alwaysTrackFinger="true"
4646
prvandroid:glowRadius="@*android:dimen/glowpadview_glow_radius"

packages/SystemUI/res/layout-sw720dp/status_bar_search_panel.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
prvandroid:outerRadius="@dimen/navbar_search_outerring_radius"
4242
prvandroid:innerRadius="@*android:dimen/glowpadview_inner_radius"
4343
prvandroid:snapMargin="@dimen/navbar_search_snap_margin"
44-
prvandroid:feedbackCount="1"
44+
prvandroid:feedbackCount="0"
4545
prvandroid:vibrationDuration="@integer/config_vibration_duration"
4646
prvandroid:alwaysTrackFinger="true"
4747
prvandroid:glowRadius="@*android:dimen/glowpadview_glow_radius"

0 commit comments

Comments
 (0)