Skip to content

Commit a3a5af0

Browse files
Sandeep SiddharthaAndroid (Google) Code Review
authored andcommitted
Merge "Add debugging info to VIS via dump()" into lmp-dev
2 parents a79e2be + 6df952e commit a3a5af0

File tree

4 files changed

+42
-5
lines changed

4 files changed

+42
-5
lines changed

core/java/android/hardware/soundtrigger/KeyphraseEnrollmentInfo.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
import org.xmlpull.v1.XmlPullParserException;
3434

3535
import java.io.IOException;
36+
import java.util.Arrays;
3637
import java.util.List;
3738

3839
/**
@@ -263,4 +264,11 @@ public KeyphraseMetadata getKeyphraseMetadata(String keyphrase, String locale) {
263264
Slog.w(TAG, "Enrollment application doesn't support the given keyphrase/locale");
264265
return null;
265266
}
267+
268+
@Override
269+
public String toString() {
270+
return "KeyphraseEnrollmentInfo [Keyphrases=" + Arrays.toString(mKeyphrases)
271+
+ ", EnrollmentPackage=" + mEnrollmentPackage + ", ParseError=" + mParseError
272+
+ "]";
273+
}
266274
}

core/java/android/service/voice/AlwaysOnHotwordDetector.java

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@
3939

4040
import com.android.internal.app.IVoiceInteractionManagerService;
4141

42+
import java.io.FileDescriptor;
43+
import java.io.PrintWriter;
4244
import java.lang.annotation.Retention;
4345
import java.lang.annotation.RetentionPolicy;
4446

@@ -490,7 +492,7 @@ private int startRecognitionLocked(int recognitionFlags) {
490492
new RecognitionConfig(captureTriggerAudio, allowMultipleTriggers,
491493
recognitionExtra, null /* additional data */));
492494
} catch (RemoteException e) {
493-
Slog.w(TAG, "RemoteException in startRecognition!");
495+
Slog.w(TAG, "RemoteException in startRecognition!", e);
494496
}
495497
if (code != STATUS_OK) {
496498
Slog.w(TAG, "startRecognition() failed with error code " + code);
@@ -504,7 +506,7 @@ private int stopRecognitionLocked() {
504506
code = mModelManagementService.stopRecognition(
505507
mVoiceInteractionService, mKeyphraseMetadata.id, mInternalCallback);
506508
} catch (RemoteException e) {
507-
Slog.w(TAG, "RemoteException in stopRecognition!");
509+
Slog.w(TAG, "RemoteException in stopRecognition!", e);
508510
}
509511

510512
if (code != STATUS_OK) {
@@ -636,7 +638,7 @@ private int internalGetInitialAvailability() {
636638
dspModuleProperties =
637639
mModelManagementService.getDspModuleProperties(mVoiceInteractionService);
638640
} catch (RemoteException e) {
639-
Slog.w(TAG, "RemoteException in getDspProperties!");
641+
Slog.w(TAG, "RemoteException in getDspProperties!", e);
640642
}
641643
// No DSP available
642644
if (dspModuleProperties == null) {
@@ -657,9 +659,20 @@ private boolean internalGetIsEnrolled(int keyphraseId) {
657659
return mModelManagementService.isEnrolledForKeyphrase(
658660
mVoiceInteractionService, keyphraseId);
659661
} catch (RemoteException e) {
660-
Slog.w(TAG, "RemoteException in listRegisteredKeyphraseSoundModels!");
662+
Slog.w(TAG, "RemoteException in listRegisteredKeyphraseSoundModels!", e);
661663
}
662664
return false;
663665
}
664666
}
667+
668+
/** @hide */
669+
public void dump(String prefix, PrintWriter pw) {
670+
synchronized (mLock) {
671+
pw.print(prefix); pw.print("Text="); pw.println(mText);
672+
pw.print(prefix); pw.print("Locale="); pw.println(mLocale);
673+
pw.print(prefix); pw.print("Availability="); pw.println(mAvailability);
674+
pw.print(prefix); pw.print("KeyphraseMetadata="); pw.println(mKeyphraseMetadata);
675+
pw.print(prefix); pw.print("EnrollmentInfo="); pw.println(mKeyphraseEnrollmentInfo);
676+
}
677+
}
665678
}

core/java/android/service/voice/VoiceInteractionService.java

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,9 @@
3333
import com.android.internal.annotations.VisibleForTesting;
3434
import com.android.internal.app.IVoiceInteractionManagerService;
3535

36+
import java.io.FileDescriptor;
37+
import java.io.PrintWriter;
38+
3639

3740
/**
3841
* Top-level service of the current global voice interactor, which is providing
@@ -244,4 +247,17 @@ private void safelyShutdownHotwordDetector() {
244247
// Ignore.
245248
}
246249
}
250+
251+
@Override
252+
protected void dump(FileDescriptor fd, PrintWriter pw, String[] args) {
253+
pw.println("VOICE INTERACTION");
254+
synchronized (mLock) {
255+
pw.println(" AlwaysOnHotwordDetector");
256+
if (mHotwordDetector == null) {
257+
pw.println(" NULL");
258+
} else {
259+
mHotwordDetector.dump(" ", pw);
260+
}
261+
}
262+
}
247263
}

services/voiceinteraction/java/com/android/server/voiceinteraction/SoundTriggerHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ int startRecognition(int keyphraseId,
159159
try {
160160
mActiveListener.onError(STATUS_ERROR);
161161
} catch (RemoteException e) {
162-
Slog.w(TAG, "RemoteException in onDetectionStopped");
162+
Slog.w(TAG, "RemoteException in onDetectionStopped", e);
163163
}
164164
mActiveListener = null;
165165
}

0 commit comments

Comments
 (0)