Skip to content

Commit 9ffc604

Browse files
Fabrice Di MeglioAndroid (Google) Code Review
authored andcommitted
Merge "Fix bug #7173155 API REVIEW: android.view.View" into jb-mr1-dev
2 parents 29d0aa7 + c11f77f commit 9ffc604

File tree

3 files changed

+2
-15
lines changed

3 files changed

+2
-15
lines changed

api/current.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24843,7 +24843,6 @@ package android.view {
2484324843
method public long getDrawingTime();
2484424844
method public boolean getFilterTouchesWhenObscured();
2484524845
method public boolean getFitsSystemWindows();
24846-
method public void getFocusRect(android.graphics.Rect);
2484724846
method public java.util.ArrayList<android.view.View> getFocusables(int);
2484824847
method public void getFocusedRect(android.graphics.Rect);
2484924848
method public boolean getGlobalVisibleRect(android.graphics.Rect, android.graphics.Point);

core/java/android/view/FocusFinder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ View findNextFocusInAbsoluteDirection(ArrayList<View> focusables, ViewGroup root
228228
if (focusable == focused || focusable == root) continue;
229229

230230
// get focus bounds of other view in same coordinate system
231-
focusable.getFocusRect(mOtherRect);
231+
focusable.getFocusedRect(mOtherRect);
232232
root.offsetDescendantRectToMyCoords(focusable, mOtherRect);
233233

234234
if (isBetterCandidate(direction, focusedRect, mOtherRect, mBestCandidateRect)) {

core/java/android/view/View.java

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -8708,18 +8708,6 @@ private void updateMatrix() {
87088708
}
87098709
}
87108710

8711-
/**
8712-
* When searching for a view to focus this rectangle is used when considering if this view is
8713-
* a good candidate for receiving focus.
8714-
*
8715-
* By default, the rectangle is the {@link #getDrawingRect}) of the view.
8716-
*
8717-
* @param r The rectangle to fill in, in this view's coordinates.
8718-
*/
8719-
public void getFocusRect(Rect r) {
8720-
getDrawingRect(r);
8721-
}
8722-
87238711
/**
87248712
* Utility method to retrieve the inverse of the current mMatrix property.
87258713
* We cache the matrix to avoid recalculating it when transform properties
@@ -9698,7 +9686,7 @@ private boolean pointInView(float localX, float localY, float slop) {
96989686
* When a view has focus and the user navigates away from it, the next view is searched for
96999687
* starting from the rectangle filled in by this method.
97009688
*
9701-
* By default, the rectange is the {@link #getDrawingRect(android.graphics.Rect)})
9689+
* By default, the rectangle is the {@link #getDrawingRect(android.graphics.Rect)})
97029690
* of the view. However, if your view maintains some idea of internal selection,
97039691
* such as a cursor, or a selected row or column, you should override this method and
97049692
* fill in a more specific rectangle.

0 commit comments

Comments
 (0)