Merge "Fixing self-assignment in cloning code."

bradfitz · Android Code Review · commit 9a01a2f27206 · 2011-03-15T11:15:19.000-07:00
diff --git a/core/java/android/app/Notification.java b/core/java/android/app/Notification.java
@@ -374,7 +374,7 @@ public Notification clone() {
         if (this.contentView != null) {
             that.contentView = this.contentView.clone();
         }
-        that.iconLevel = that.iconLevel;
+        that.iconLevel = this.iconLevel;
         that.sound = this.sound; // android.net.Uri is immutable
         that.audioStreamType = this.audioStreamType;
 

Original file line number	Diff line number	Diff line change
`@@ -374,7 +374,7 @@ public Notification clone() {`
`374`	`374`	`if (this.contentView != null) {`
`375`	`375`	`that.contentView = this.contentView.clone();`
`376`	`376`	`}`
`377`		`- that.iconLevel = that.iconLevel;`
	`377`	`+ that.iconLevel = this.iconLevel;`
`378`	`378`	`that.sound = this.sound; // android.net.Uri is immutable`
`379`	`379`	`that.audioStreamType = this.audioStreamType;`
`380`	`380`