Skip to content

Commit 95cccb9

Browse files
jsharkeyAndroid (Google) Code Review
authored andcommitted
Merge "Make all lockscreen widgets follow haptic flag." into jb-mr1-dev
2 parents 6b77a76 + 723a725 commit 95cccb9

File tree

6 files changed

+47
-16
lines changed

6 files changed

+47
-16
lines changed

core/java/com/android/internal/widget/RotarySelector.java

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,9 @@
2525
import android.graphics.BitmapFactory;
2626
import android.graphics.Matrix;
2727
import android.graphics.drawable.Drawable;
28+
import android.os.UserHandle;
2829
import android.os.Vibrator;
30+
import android.provider.Settings;
2931
import android.util.AttributeSet;
3032
import android.util.Log;
3133
import android.view.MotionEvent;
@@ -667,11 +669,16 @@ private void reset() {
667669
* Triggers haptic feedback.
668670
*/
669671
private synchronized void vibrate(long duration) {
670-
if (mVibrator == null) {
671-
mVibrator = (android.os.Vibrator)
672-
getContext().getSystemService(Context.VIBRATOR_SERVICE);
672+
final boolean hapticEnabled = Settings.System.getIntForUser(
673+
mContext.getContentResolver(), Settings.System.HAPTIC_FEEDBACK_ENABLED, 1,
674+
UserHandle.USER_CURRENT) != 0;
675+
if (hapticEnabled) {
676+
if (mVibrator == null) {
677+
mVibrator = (android.os.Vibrator) getContext()
678+
.getSystemService(Context.VIBRATOR_SERVICE);
679+
}
680+
mVibrator.vibrate(duration);
673681
}
674-
mVibrator.vibrate(duration);
675682
}
676683

677684
/**

core/java/com/android/internal/widget/SlidingTab.java

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,9 @@
2121
import android.content.res.TypedArray;
2222
import android.graphics.Rect;
2323
import android.graphics.drawable.Drawable;
24+
import android.os.UserHandle;
2425
import android.os.Vibrator;
26+
import android.provider.Settings;
2527
import android.util.AttributeSet;
2628
import android.util.Log;
2729
import android.view.Gravity;
@@ -811,11 +813,16 @@ public void setHoldAfterTrigger(boolean holdLeft, boolean holdRight) {
811813
* Triggers haptic feedback.
812814
*/
813815
private synchronized void vibrate(long duration) {
814-
if (mVibrator == null) {
815-
mVibrator = (android.os.Vibrator)
816-
getContext().getSystemService(Context.VIBRATOR_SERVICE);
816+
final boolean hapticEnabled = Settings.System.getIntForUser(
817+
mContext.getContentResolver(), Settings.System.HAPTIC_FEEDBACK_ENABLED, 1,
818+
UserHandle.USER_CURRENT) != 0;
819+
if (hapticEnabled) {
820+
if (mVibrator == null) {
821+
mVibrator = (android.os.Vibrator) getContext()
822+
.getSystemService(Context.VIBRATOR_SERVICE);
823+
}
824+
mVibrator.vibrate(duration);
817825
}
818-
mVibrator.vibrate(duration);
819826
}
820827

821828
/**

core/java/com/android/internal/widget/WaveView.java

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,9 @@
2525
import android.graphics.BitmapFactory;
2626
import android.graphics.Canvas;
2727
import android.graphics.drawable.BitmapDrawable;
28+
import android.os.UserHandle;
2829
import android.os.Vibrator;
30+
import android.provider.Settings;
2931
import android.text.TextUtils;
3032
import android.util.AttributeSet;
3133
import android.util.Log;
@@ -573,11 +575,16 @@ private void announceUnlockHandle() {
573575
* Triggers haptic feedback.
574576
*/
575577
private synchronized void vibrate(long duration) {
576-
if (mVibrator == null) {
577-
mVibrator = (android.os.Vibrator)
578-
getContext().getSystemService(Context.VIBRATOR_SERVICE);
578+
final boolean hapticEnabled = Settings.System.getIntForUser(
579+
mContext.getContentResolver(), Settings.System.HAPTIC_FEEDBACK_ENABLED, 1,
580+
UserHandle.USER_CURRENT) != 0;
581+
if (hapticEnabled) {
582+
if (mVibrator == null) {
583+
mVibrator = (android.os.Vibrator) getContext()
584+
.getSystemService(Context.VIBRATOR_SERVICE);
585+
}
586+
mVibrator.vibrate(duration);
579587
}
580-
mVibrator.vibrate(duration);
581588
}
582589

583590
/**

core/java/com/android/internal/widget/multiwaveview/GlowPadView.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,9 @@
3131
import android.graphics.Canvas;
3232
import android.graphics.drawable.Drawable;
3333
import android.os.Bundle;
34+
import android.os.UserHandle;
3435
import android.os.Vibrator;
36+
import android.provider.Settings;
3537
import android.text.TextUtils;
3638
import android.util.AttributeSet;
3739
import android.util.Log;
@@ -543,7 +545,10 @@ private void showTargets(boolean animate) {
543545
}
544546

545547
private void vibrate() {
546-
if (mVibrator != null) {
548+
final boolean hapticEnabled = Settings.System.getIntForUser(
549+
mContext.getContentResolver(), Settings.System.HAPTIC_FEEDBACK_ENABLED, 1,
550+
UserHandle.USER_CURRENT) != 0;
551+
if (mVibrator != null && hapticEnabled) {
547552
mVibrator.vibrate(mVibrationDuration);
548553
}
549554
}

core/java/com/android/internal/widget/multiwaveview/MultiWaveView.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,9 @@
3232
import android.graphics.RectF;
3333
import android.graphics.drawable.Drawable;
3434
import android.os.Bundle;
35+
import android.os.UserHandle;
3536
import android.os.Vibrator;
37+
import android.provider.Settings;
3638
import android.text.TextUtils;
3739
import android.util.AttributeSet;
3840
import android.util.Log;
@@ -593,7 +595,10 @@ private void showTargets(boolean animate) {
593595
}
594596

595597
private void vibrate() {
596-
if (mVibrator != null) {
598+
final boolean hapticEnabled = Settings.System.getIntForUser(
599+
mContext.getContentResolver(), Settings.System.HAPTIC_FEEDBACK_ENABLED, 1,
600+
UserHandle.USER_CURRENT) != 0;
601+
if (mVibrator != null && hapticEnabled) {
597602
mVibrator.vibrate(mVibrationDuration);
598603
}
599604
}

packages/SystemUI/src/com/android/systemui/SearchPanelView.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,8 +184,8 @@ public boolean onPreDraw() {
184184

185185
private void vibrate() {
186186
Context context = getContext();
187-
if (Settings.System.getInt(context.getContentResolver(),
188-
Settings.System.HAPTIC_FEEDBACK_ENABLED, 1) != 0) {
187+
if (Settings.System.getIntForUser(context.getContentResolver(),
188+
Settings.System.HAPTIC_FEEDBACK_ENABLED, 1, UserHandle.USER_CURRENT) != 0) {
189189
Resources res = context.getResources();
190190
Vibrator vibrator = (Vibrator) context.getSystemService(Context.VIBRATOR_SERVICE);
191191
vibrator.vibrate(res.getInteger(R.integer.config_search_panel_view_vibration_duration));

0 commit comments

Comments
 (0)