Skip to content

Commit 8abea42

Browse files
author
Santos Cordon
committed
Remove ldaps from AOSP code.
Bug: 16327484 Change-Id: I1fbeed8e1642e8228310cf0e7b95c4809b50901b
1 parent 3da5ba0 commit 8abea42

File tree

5 files changed

+7
-11
lines changed

5 files changed

+7
-11
lines changed

telecomm/java/android/telecomm/Call.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ public static abstract class Listener {
249249
/**
250250
* Invoked when the state of this {@code Call} has changed. See {@link #getState()}.
251251
*
252-
* TODO(ihab): Provide previous state also?
252+
* TODO: Provide previous state also?
253253
*
254254
* @param call The {@code Call} invoking this method.
255255
* @param state The new state of the {@code Call}.
@@ -453,7 +453,7 @@ public void postDialContinue(boolean proceed) {
453453
/**
454454
* Notifies this {@code Call} that the phone account user interface element was touched.
455455
*
456-
* TODO(ihab): Figure out if and how we can generalize this
456+
* TODO: Figure out if and how we can generalize this
457457
*/
458458
public void phoneAccountClicked() {
459459
mInCallAdapter.phoneAccountClicked(mTelecommCallId);

telecomm/java/android/telecomm/Connection.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ public static String stateToString(int state) {
273273
}
274274

275275
/**
276-
* TODO(santoscordon): Needs documentation.
276+
* TODO: Needs documentation.
277277
*/
278278
public final void setParentConnection(Connection parentConnection) {
279279
Log.d(this, "parenting %s to %s", this, parentConnection);
@@ -458,7 +458,7 @@ public final void setDisconnected(int cause, String message) {
458458
}
459459

460460
/**
461-
* TODO(santoscordon): Needs documentation.
461+
* TODO: Needs documentation.
462462
*/
463463
public final void setPostDialWait(String remaining) {
464464
for (Listener l : mListeners) {
@@ -654,7 +654,7 @@ public void onPostDialContinue(boolean proceed) {}
654654
public void onSwapWithBackgroundCall() {}
655655

656656
/**
657-
* TODO(santoscordon): Needs documentation.
657+
* TODO: Needs documentation.
658658
*/
659659
public void onChildrenChanged(List<Connection> children) {}
660660

telecomm/java/android/telecomm/ConnectionService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -647,7 +647,7 @@ private void splitFromConference(String callId) {
647647
return;
648648
}
649649

650-
// TODO(santoscordon): Find existing conference call and invoke split(connection).
650+
// TODO: Find existing conference call and invoke split(connection).
651651
}
652652

653653
private void swapWithBackgroundCall(String callId) {

telecomm/java/android/telecomm/InCallAdapter.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@
2828
* given call IDs to execute commands such as {@link #answerCall} for incoming calls or
2929
* {@link #disconnectCall} for active calls the user would like to end. Some commands are only
3030
* appropriate for calls in certain states; please consult each method for such limitations.
31-
* TODO(santoscordon): Needs more/better comments once the API is finalized.
32-
* TODO(santoscordon): Specify the adapter will stop functioning when there are no more calls.
3331
*/
3432
public final class InCallAdapter {
3533
private final IInCallAdapter mAdapter;
@@ -56,8 +54,6 @@ public void answerCall(String callId, int videoState) {
5654

5755
/**
5856
* Instructs Telecomm to reject the specified call.
59-
* TODO(santoscordon): Add reject-with-text-message parameter when that feature
60-
* is ported over.
6157
*
6258
* @param callId The identifier of the call to reject.
6359
* @param rejectWithMessage Whether to reject with a text message.

telecomm/java/android/telecomm/InCallService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
* This service is implemented by any app that wishes to provide the user-interface for managing
3636
* phone calls. Telecomm binds to this service while there exists a live (active or incoming) call,
3737
* and uses it to notify the in-call app of any live and and recently disconnected calls.
38-
* TODO(santoscordon): What happens if two or more apps on a given device implement this interface?
38+
* TODO: What happens if two or more apps on a given device implement this interface?
3939
*/
4040
public abstract class InCallService extends Service {
4141
private static final int MSG_SET_IN_CALL_ADAPTER = 1;

0 commit comments

Comments
 (0)