Skip to content

Commit 8a71888

Browse files
cwrenAndroid (Google) Code Review
authored andcommitted
Merge "Fix notification icon fading." into jb-dev
2 parents 44b2fe3 + 67e7d90 commit 8a71888

File tree

1 file changed

+25
-11
lines changed

1 file changed

+25
-11
lines changed

packages/SystemUI/src/com/android/systemui/statusbar/phone/PhoneStatusBar.java

Lines changed: 25 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@
6565
import android.view.animation.AccelerateInterpolator;
6666
import android.view.animation.Animation;
6767
import android.view.animation.AnimationUtils;
68+
import android.view.animation.DecelerateInterpolator;
6869
import android.widget.FrameLayout;
6970
import android.widget.ImageView;
7071
import android.widget.LinearLayout;
@@ -230,13 +231,11 @@ public class PhoneStatusBar extends BaseStatusBar {
230231
private final Animator.AnimatorListener mMakeIconsInvisible = new AnimatorListenerAdapter() {
231232
@Override
232233
public void onAnimationEnd(Animator animation) {
233-
mIcons.setVisibility(View.INVISIBLE);
234-
}
235-
};
236-
private final Animator.AnimatorListener mMakeIconsVisible = new AnimatorListenerAdapter() {
237-
@Override
238-
public void onAnimationEnd(Animator animation) {
239-
mIcons.setVisibility(View.VISIBLE);
234+
// double-check to avoid races
235+
if (mIcons.getAlpha() == 0) {
236+
Slog.d(TAG, "makeIconsInvisible");
237+
mIcons.setVisibility(View.INVISIBLE);
238+
}
240239
}
241240
};
242241

@@ -968,11 +967,26 @@ public void disable(int state) {
968967
if ((diff & StatusBarManager.DISABLE_SYSTEM_INFO) != 0) {
969968
mIcons.animate().cancel();
970969
if ((state & StatusBarManager.DISABLE_SYSTEM_INFO) != 0) {
971-
mIcons.animate().alpha(0f).setStartDelay(100).setDuration(200).
972-
setListener(mMakeIconsInvisible).start();
970+
if (mTicking) {
971+
mTicker.halt();
972+
}
973+
mIcons.animate()
974+
.alpha(0f)
975+
.translationY(mNaturalBarHeight*0.5f)
976+
//.setStartDelay(100)
977+
.setDuration(175)
978+
.setInterpolator(new DecelerateInterpolator(1.5f))
979+
.setListener(mMakeIconsInvisible)
980+
.start();
973981
} else {
974-
mIcons.animate().alpha(1f).setStartDelay(0).setDuration(300).
975-
setListener(mMakeIconsVisible).start();
982+
mIcons.setVisibility(View.VISIBLE);
983+
mIcons.animate()
984+
.alpha(1f)
985+
.translationY(0)
986+
.setStartDelay(0)
987+
.setInterpolator(new DecelerateInterpolator(1.5f))
988+
.setDuration(175)
989+
.start();
976990
}
977991
}
978992

0 commit comments

Comments
 (0)