Skip to content

Commit 87a36a3

Browse files
Alex SakhartchoukAndroid (Google) Code Review
authored andcommitted
Merge "Making shader compilation errors throw a Java exception."
2 parents f0451db + 257e8a9 commit 87a36a3

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

libs/rs/driver/rsdShader.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,12 +195,11 @@ bool RsdShader::loadShader(const Context *rsc) {
195195
char* buf = (char*) malloc(infoLen);
196196
if (buf) {
197197
RSD_CALL_GL(glGetShaderInfoLog, mShaderID, infoLen, NULL, buf);
198-
ALOGE("Could not compile shader \n%s\n", buf);
198+
rsc->setError(RS_ERROR_FATAL_PROGRAM_LINK, buf);
199199
free(buf);
200200
}
201201
RSD_CALL_GL(glDeleteShader, mShaderID);
202202
mShaderID = 0;
203-
rsc->setError(RS_ERROR_BAD_SHADER, "Error returned from GL driver loading shader text,");
204203
return false;
205204
}
206205
}

libs/rs/driver/rsdShaderCache.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,12 +167,11 @@ bool RsdShaderCache::link(const Context *rsc) {
167167
char* buf = (char*) malloc(bufLength);
168168
if (buf) {
169169
glGetProgramInfoLog(pgm, bufLength, NULL, buf);
170-
ALOGE("Could not link program:\n%s\n", buf);
170+
rsc->setError(RS_ERROR_FATAL_PROGRAM_LINK, buf);
171171
free(buf);
172172
}
173173
}
174174
glDeleteProgram(pgm);
175-
rsc->setError(RS_ERROR_FATAL_PROGRAM_LINK, "Error linking GL Programs");
176175
return false;
177176
}
178177

0 commit comments

Comments
 (0)