Skip to content

Commit 86b7349

Browse files
Christopher TateAndroid (Google) Code Review
authored andcommitted
Merge "Enforce DUMP permission on BackupManagerService's dump() method"
2 parents 638f17c + b8491bb commit 86b7349

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

services/java/com/android/server/BackupManagerService.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5596,6 +5596,16 @@ public void dump(FileDescriptor fd, PrintWriter pw, String[] args) {
55965596
}
55975597

55985598
private void dumpInternal(PrintWriter pw) {
5599+
if (mContext.checkCallingOrSelfPermission(android.Manifest.permission.DUMP)
5600+
!= PackageManager.PERMISSION_GRANTED) {
5601+
pw.println("Permission Denial: can't dump Backup Manager service from from pid="
5602+
+ Binder.getCallingPid()
5603+
+ ", uid=" + Binder.getCallingUid()
5604+
+ " without permission "
5605+
+ android.Manifest.permission.DUMP);
5606+
return;
5607+
}
5608+
55995609
synchronized (mQueueLock) {
56005610
pw.println("Backup Manager is " + (mEnabled ? "enabled" : "disabled")
56015611
+ " / " + (!mProvisioned ? "not " : "") + "provisioned / "

0 commit comments

Comments
 (0)