Skip to content

Commit 7d5b22a

Browse files
krutonAndroid Git Automerger
authored andcommitted
am f029c22: Merge "Use Libcore.os.umask for setting umask"
* commit 'f029c22f82573e7fee7c7e0cca4439fe78300bac': Use Libcore.os.umask for setting umask
2 parents 69b6a32 + f029c22 commit 7d5b22a

File tree

3 files changed

+5
-11
lines changed

3 files changed

+5
-11
lines changed

core/java/android/os/FileUtils.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,6 @@ public class FileUtils {
5353

5454
public static native int setPermissions(String file, int mode, int uid, int gid);
5555

56-
public static native int setUMask(int mask);
57-
5856
/** returns the FAT file system volume ID for the volume mounted
5957
* at the given mount point, or -1 for failure
6058
* @param mountPoint point for FAT volume

core/java/com/android/internal/os/ZygoteInit.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,23 +16,25 @@
1616

1717
package com.android.internal.os;
1818

19+
import static libcore.io.OsConstants.S_IRWXG;
20+
import static libcore.io.OsConstants.S_IRWXO;
21+
1922
import android.content.pm.ActivityInfo;
2023
import android.content.res.Resources;
2124
import android.content.res.TypedArray;
2225
import android.graphics.drawable.Drawable;
2326
import android.net.LocalServerSocket;
2427
import android.os.Debug;
25-
import android.os.FileUtils;
2628
import android.os.Process;
2729
import android.os.SystemClock;
28-
import android.os.SystemProperties;
2930
import android.util.EventLog;
3031
import android.util.Log;
3132

3233
import dalvik.system.VMRuntime;
3334
import dalvik.system.Zygote;
3435

3536
import libcore.io.IoUtils;
37+
import libcore.io.Libcore;
3638

3739
import java.io.BufferedReader;
3840
import java.io.FileDescriptor;
@@ -447,7 +449,7 @@ private static void handleSystemServerProcess(
447449
closeServerSocket();
448450

449451
// set umask to 0077 so new files and directories will default to owner-only permissions.
450-
FileUtils.setUMask(FileUtils.S_IRWXG | FileUtils.S_IRWXO);
452+
Libcore.os.umask(S_IRWXG | S_IRWXO);
451453

452454
if (parsedArgs.niceName != null) {
453455
Process.setArgV0(parsedArgs.niceName);

core/jni/android_os_FileUtils.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,6 @@ jint android_os_FileUtils_setPermissions(JNIEnv* env, jobject clazz,
5555
return chmod(file8.string(), mode) == 0 ? 0 : errno;
5656
}
5757

58-
jint android_os_FileUtils_setUMask(JNIEnv* env, jobject clazz, jint mask)
59-
{
60-
return umask(mask);
61-
}
62-
6358
jint android_os_FileUtils_getFatVolumeId(JNIEnv* env, jobject clazz, jstring path)
6459
{
6560
if (path == NULL) {
@@ -83,7 +78,6 @@ jint android_os_FileUtils_getFatVolumeId(JNIEnv* env, jobject clazz, jstring pat
8378

8479
static const JNINativeMethod methods[] = {
8580
{"setPermissions", "(Ljava/lang/String;III)I", (void*)android_os_FileUtils_setPermissions},
86-
{"setUMask", "(I)I", (void*)android_os_FileUtils_setUMask},
8781
{"getFatVolumeId", "(Ljava/lang/String;)I", (void*)android_os_FileUtils_getFatVolumeId},
8882
};
8983

0 commit comments

Comments
 (0)