Skip to content

Commit 7c70cef

Browse files
author
John Wang
committed
Don't use SNR in the invalid check.
Since some RILs use -1 instead of INVALID_SNR as invalid vlue for LTE SNR, SignalStrength will not use LTE SNR to check if LTE valid. bug:5970403 Change-Id: Ia948e076f8f5878e081e87680076b187857879c8
1 parent f8aea99 commit 7c70cef

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

telephony/java/android/telephony/SignalStrength.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -293,10 +293,11 @@ public int getLevel() {
293293
int level;
294294

295295
if (isGsm) {
296+
// TODO Need solve the discrepancy of invalid values between
297+
// RIL_LTE_SignalStrength and here.
296298
if ((mLteSignalStrength == -1)
297299
&& (mLteRsrp == -1)
298300
&& (mLteRsrq == -1)
299-
&& (mLteRssnr == INVALID_SNR)
300301
&& (mLteCqi == -1)) {
301302
level = getGsmLevel();
302303
} else {
@@ -331,7 +332,6 @@ public int getAsuLevel() {
331332
if ((mLteSignalStrength == -1)
332333
&& (mLteRsrp == -1)
333334
&& (mLteRsrq == -1)
334-
&& (mLteRssnr == INVALID_SNR)
335335
&& (mLteCqi == -1)) {
336336
asuLevel = getGsmAsuLevel();
337337
} else {
@@ -367,7 +367,6 @@ public int getDbm() {
367367
if ((mLteSignalStrength == -1)
368368
&& (mLteRsrp == -1)
369369
&& (mLteRsrq == -1)
370-
&& (mLteRssnr == INVALID_SNR)
371370
&& (mLteCqi == -1)) {
372371
dBm = getGsmDbm();
373372
} else {

0 commit comments

Comments
 (0)