Skip to content

Commit 7b8bec2

Browse files
sganovAndroid (Google) Code Review
authored andcommitted
Merge "PopupWindow dismiss() can get into a recursive loop." into ics-mr0
2 parents 30f03ac + 06f938e commit 7b8bec2

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

core/java/android/widget/PopupWindow.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1248,6 +1248,8 @@ public int getMaxAvailableHeight(View anchor, int yOffset, boolean ignoreBottomD
12481248
*/
12491249
public void dismiss() {
12501250
if (isShowing() && mPopupView != null) {
1251+
mIsShowing = false;
1252+
12511253
unregisterForScrollChanged();
12521254

12531255
try {
@@ -1257,7 +1259,6 @@ public void dismiss() {
12571259
((ViewGroup) mPopupView).removeView(mContentView);
12581260
}
12591261
mPopupView = null;
1260-
mIsShowing = false;
12611262

12621263
if (mOnDismissListener != null) {
12631264
mOnDismissListener.onDismiss();

0 commit comments

Comments
 (0)