Skip to content

Commit 7877016

Browse files
mikejurkaAndroid (Google) Code Review
authored andcommitted
Merge "Fixing preloading recents for all devices" into jb-mr1-dev
2 parents 881f0b1 + d0d4bb8 commit 7877016

File tree

3 files changed

+14
-20
lines changed

3 files changed

+14
-20
lines changed

packages/SystemUI/src/com/android/systemui/recent/RecentTasksLoader.java

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -253,10 +253,9 @@ public void run() {
253253
public boolean onTouch(View v, MotionEvent ev) {
254254
int action = ev.getAction() & MotionEvent.ACTION_MASK;
255255
if (action == MotionEvent.ACTION_DOWN) {
256-
mHandler.post(mPreloadTasksRunnable);
256+
preloadRecentTasksList();
257257
} else if (action == MotionEvent.ACTION_CANCEL) {
258-
cancelLoadingThumbnailsAndIcons();
259-
mHandler.removeCallbacks(mPreloadTasksRunnable);
258+
cancelPreloadingRecentTasksList();
260259
} else if (action == MotionEvent.ACTION_UP) {
261260
// Remove the preloader if we haven't called it yet
262261
mHandler.removeCallbacks(mPreloadTasksRunnable);
@@ -268,6 +267,15 @@ public boolean onTouch(View v, MotionEvent ev) {
268267
return false;
269268
}
270269

270+
public void preloadRecentTasksList() {
271+
mHandler.post(mPreloadTasksRunnable);
272+
}
273+
274+
public void cancelPreloadingRecentTasksList() {
275+
cancelLoadingThumbnailsAndIcons();
276+
mHandler.removeCallbacks(mPreloadTasksRunnable);
277+
}
278+
271279
public void cancelLoadingThumbnailsAndIcons(RecentsPanelView caller) {
272280
// Only oblige this request if it comes from the current RecentsPanel
273281
// (eg when you rotate, the old RecentsPanel request should be ignored)

packages/SystemUI/src/com/android/systemui/statusbar/BaseStatusBar.java

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -594,25 +594,11 @@ public void handleMessage(Message m) {
594594
break;
595595
case MSG_PRELOAD_RECENT_APPS:
596596
if (DEBUG) Slog.d(TAG, "preloading recents");
597-
{
598-
// TODO:
599-
// need to implement this
600-
//final RecentsPanelView recentsPanel = getRecentsPanel();
601-
//if (recentsPanel != null) {
602-
//recentsPanel.preloadRecentTasksList();
603-
//}
604-
}
597+
getRecentTasksLoader().preloadRecentTasksList();
605598
break;
606599
case MSG_CANCEL_PRELOAD_RECENT_APPS:
607600
if (DEBUG) Slog.d(TAG, "cancel preloading recents");
608-
{
609-
// TODO:
610-
// need to implement this
611-
//final RecentsPanelView recentsPanel = getRecentsPanel();
612-
//if (recentsPanel != null) {
613-
//recentsPanel.clearRecentTasksList();
614-
//}
615-
}
601+
getRecentTasksLoader().cancelPreloadingRecentTasksList();
616602
break;
617603
case MSG_OPEN_SEARCH_PANEL:
618604
if (DEBUG) Slog.d(TAG, "opening search panel");

packages/SystemUI/src/com/android/systemui/statusbar/tablet/TabletStatusBar.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,7 @@ protected void addPanelWindows() {
355355

356356
mWindowManager.addView(mCompatModePanel, lp);
357357

358-
//mRecentButton.setOnTouchListener(mRecentsPanel); //TODO: plumb this
358+
mRecentButton.setOnTouchListener(getRecentTasksLoader());
359359

360360
mPile = (NotificationRowLayout)mNotificationPanel.findViewById(R.id.content);
361361
mPile.removeAllViews();

0 commit comments

Comments
 (0)