Skip to content

Commit 72b8fc7

Browse files
Victoria LeaseAndroid (Google) Code Review
authored andcommitted
Merge "Revert "Fix fake bold for fallback fonts in frameworks."" into jb-dev
2 parents fbce66c + aa0980a commit 72b8fc7

File tree

5 files changed

+2
-9
lines changed

5 files changed

+2
-9
lines changed

core/java/android/text/style/StyleSpan.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ private static void apply(Paint paint, int style) {
9898
}
9999

100100
int fake = want & ~tf.getStyle();
101-
fake |= tf.getStyle() & Typeface.BOLD;
102101

103102
if ((fake & Typeface.BOLD) != 0) {
104103
paint.setFakeBoldText(true);

core/java/android/text/style/TextAppearanceSpan.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,6 @@ public void updateMeasureState(TextPaint ds) {
235235
}
236236

237237
int fake = style & ~tf.getStyle();
238-
fake |= tf.getStyle() & Typeface.BOLD;
239238

240239
if ((fake & Typeface.BOLD) != 0) {
241240
ds.setFakeBoldText(true);

core/java/android/text/style/TypefaceSpan.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ private static void apply(Paint paint, String family) {
8282

8383
Typeface tf = Typeface.create(family, oldStyle);
8484
int fake = oldStyle & ~tf.getStyle();
85-
fake |= tf.getStyle() & Typeface.BOLD;
8685

8786
if ((fake & Typeface.BOLD) != 0) {
8887
paint.setFakeBoldText(true);

core/java/android/widget/Switch.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -259,12 +259,10 @@ public void setSwitchTypeface(Typeface tf, int style) {
259259
// now compute what (if any) algorithmic styling is needed
260260
int typefaceStyle = tf != null ? tf.getStyle() : 0;
261261
int need = style & ~typefaceStyle;
262-
need |= typefaceStyle & Typeface.BOLD;
263262
mTextPaint.setFakeBoldText((need & Typeface.BOLD) != 0);
264263
mTextPaint.setTextSkewX((need & Typeface.ITALIC) != 0 ? -0.25f : 0);
265264
} else {
266-
int typefaceStyle = tf != null ? tf.getStyle() : 0;
267-
mTextPaint.setFakeBoldText((typefaceStyle & Typeface.BOLD) != 0);
265+
mTextPaint.setFakeBoldText(false);
268266
mTextPaint.setTextSkewX(0);
269267
setSwitchTypeface(tf);
270268
}

core/java/android/widget/TextView.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1237,12 +1237,10 @@ public void setTypeface(Typeface tf, int style) {
12371237
// now compute what (if any) algorithmic styling is needed
12381238
int typefaceStyle = tf != null ? tf.getStyle() : 0;
12391239
int need = style & ~typefaceStyle;
1240-
need |= typefaceStyle & Typeface.BOLD; // keep bold in
12411240
mTextPaint.setFakeBoldText((need & Typeface.BOLD) != 0);
12421241
mTextPaint.setTextSkewX((need & Typeface.ITALIC) != 0 ? -0.25f : 0);
12431242
} else {
1244-
int typefaceStyle = tf != null ? tf.getStyle() : 0;
1245-
mTextPaint.setFakeBoldText((typefaceStyle & Typeface.BOLD) != 0);
1243+
mTextPaint.setFakeBoldText(false);
12461244
mTextPaint.setTextSkewX(0);
12471245
setTypeface(tf);
12481246
}

0 commit comments

Comments
 (0)