Skip to content

Commit 6cf3b92

Browse files
Jeff BrownAndroid (Google) Code Review
authored andcommitted
Merge "Fix auto-brightness adjustment sentinel value." into jb-mr1-dev
2 parents 6da9203 + 5d03a53 commit 6cf3b92

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

services/java/com/android/server/power/PowerManagerService.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -405,7 +405,7 @@ private void updateSettingsLocked() {
405405
mScreenAutoBrightnessAdjustmentSetting = Settings.System.getFloat(resolver,
406406
Settings.System.SCREEN_AUTO_BRIGHTNESS_ADJ, 0.0f);
407407
if (oldScreenAutoBrightnessAdjustmentSetting != mScreenAutoBrightnessAdjustmentSetting) {
408-
mTemporaryScreenAutoBrightnessAdjustmentSettingOverride = -1;
408+
mTemporaryScreenAutoBrightnessAdjustmentSettingOverride = Float.NaN;
409409
}
410410

411411
mScreenBrightnessModeSetting = Settings.System.getInt(resolver,
@@ -1347,7 +1347,8 @@ private static boolean isValidBrightness(int value) {
13471347
}
13481348

13491349
private static boolean isValidAutoBrightnessAdjustment(float value) {
1350-
return !Float.isNaN(value);
1350+
// Handles NaN by always returning false.
1351+
return value >= -1.0f && value <= 1.0f;
13511352
}
13521353

13531354
private int getDesiredScreenPowerState() {

0 commit comments

Comments
 (0)