Skip to content

Commit 6cf14a0

Browse files
committed
Fix NPE on tablets.
Change-Id: I2128daac06988e4bae25ec48a874901ba731ebf9
1 parent fb32ab9 commit 6cf14a0

File tree

1 file changed

+1
-22
lines changed

1 file changed

+1
-22
lines changed

packages/SystemUI/src/com/android/systemui/statusbar/tablet/TabletStatusBar.java

Lines changed: 1 addition & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -936,10 +936,8 @@ public void updateNotification(IBinder key, StatusBarNotification notification)
936936
if (contentIntent != null) {
937937
final View.OnClickListener listener = new NotificationClicker(contentIntent,
938938
notification.pkg, notification.tag, notification.id);
939-
oldEntry.largeIcon.setOnClickListener(listener);
940939
oldEntry.content.setOnClickListener(listener);
941940
} else {
942-
oldEntry.largeIcon.setOnClickListener(null);
943941
oldEntry.content.setOnClickListener(null);
944942
}
945943
// Update the icon.
@@ -951,13 +949,6 @@ public void updateNotification(IBinder key, StatusBarNotification notification)
951949
handleNotificationError(key, notification, "Couldn't update icon: " + ic);
952950
return;
953951
}
954-
// Update the large icon
955-
if (notification.notification.largeIcon != null) {
956-
oldEntry.largeIcon.setImageBitmap(notification.notification.largeIcon);
957-
} else {
958-
oldEntry.largeIcon.getLayoutParams().width = 0;
959-
oldEntry.largeIcon.setVisibility(View.INVISIBLE);
960-
}
961952

962953
if (NOTIFICATION_PEEK_ENABLED && key == mNotificationPeekKey) {
963954
// must update the peek window
@@ -1860,16 +1851,7 @@ private boolean inflateViews(NotificationData.Entry entry, ViewGroup parent) {
18601851
vetoButton.setContentDescription(mContext.getString(
18611852
R.string.accessibility_remove_notification));
18621853

1863-
// the large icon
1864-
ImageView largeIcon = (ImageView)row.findViewById(R.id.large_icon);
1865-
if (sbn.notification.largeIcon != null) {
1866-
largeIcon.setImageBitmap(sbn.notification.largeIcon);
1867-
largeIcon.setContentDescription(sbn.notification.tickerText);
1868-
} else {
1869-
largeIcon.getLayoutParams().width = 0;
1870-
largeIcon.setVisibility(View.INVISIBLE);
1871-
}
1872-
largeIcon.setContentDescription(sbn.notification.tickerText);
1854+
// NB: the large icon is now handled entirely by the template
18731855

18741856
// bind the click event to the content area
18751857
ViewGroup content = (ViewGroup)row.findViewById(R.id.content);
@@ -1880,10 +1862,8 @@ private boolean inflateViews(NotificationData.Entry entry, ViewGroup parent) {
18801862
if (contentIntent != null) {
18811863
final View.OnClickListener listener = new NotificationClicker(
18821864
contentIntent, sbn.pkg, sbn.tag, sbn.id);
1883-
largeIcon.setOnClickListener(listener);
18841865
content.setOnClickListener(listener);
18851866
} else {
1886-
largeIcon.setOnClickListener(null);
18871867
content.setOnClickListener(null);
18881868
}
18891869

@@ -1909,7 +1889,6 @@ private boolean inflateViews(NotificationData.Entry entry, ViewGroup parent) {
19091889
entry.row = row;
19101890
entry.content = content;
19111891
entry.expanded = expanded;
1912-
entry.largeIcon = largeIcon;
19131892

19141893
return true;
19151894
}

0 commit comments

Comments
 (0)