Return error code when composing PDU fails

Matthias Thomae · Matthias Thomae · commit 54c3ce2f14b8 · 2012-02-16T11:17:39.000+01:00
When the PduComposer fails to make the message body,
a successful result code was still returned.

Change-Id: I8a677afeeae8811c3b0fae61209c5348df1e39d9
diff --git a/core/java/com/google/android/mms/pdu/PduComposer.java b/core/java/com/google/android/mms/pdu/PduComposer.java
@@ -835,9 +835,7 @@ private int makeSendReqPdu() {
         appendOctet(PduHeaders.CONTENT_TYPE);
 
         //  Message body
-        makeMessageBody();
-
-        return PDU_COMPOSE_SUCCESS;  // Composing the message is OK
+        return makeMessageBody();
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -835,9 +835,7 @@ private int makeSendReqPdu() {`
`835`	`835`	`appendOctet(PduHeaders.CONTENT_TYPE);`
`836`	`836`
`837`	`837`	`// Message body`
`838`		`- makeMessageBody();`
`839`		`-`
`840`		`- return PDU_COMPOSE_SUCCESS; // Composing the message is OK`
	`838`	`+ return makeMessageBody();`
`841`	`839`	`}`
`842`	`840`
`843`	`841`	`/**`