Skip to content

Commit 532c9c4

Browse files
jsharkeyAndroid (Google) Code Review
authored andcommitted
Merge "Protect more service dump() methods." into jb-mr1-dev
2 parents a30d969 + 52801aa commit 532c9c4

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

core/java/android/server/search/SearchManagerService.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -283,6 +283,8 @@ public ComponentName getAssistIntent(int userHandle) {
283283

284284
@Override
285285
public void dump(FileDescriptor fd, PrintWriter pw, String[] args) {
286+
mContext.enforceCallingOrSelfPermission(android.Manifest.permission.DUMP, TAG);
287+
286288
IndentingPrintWriter ipw = new IndentingPrintWriter(pw, " ");
287289
synchronized (mSearchables) {
288290
for (int i = 0; i < mSearchables.size(); i++) {

services/java/com/android/server/AppWidgetService.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -304,6 +304,8 @@ public void updateAppWidgetProvider(ComponentName provider, RemoteViews views)
304304

305305
@Override
306306
public void dump(FileDescriptor fd, PrintWriter pw, String[] args) {
307+
mContext.enforceCallingOrSelfPermission(android.Manifest.permission.DUMP, TAG);
308+
307309
// Dump the state of all the app widget providers
308310
synchronized (mAppWidgetServices) {
309311
IndentingPrintWriter ipw = new IndentingPrintWriter(pw, " ");

0 commit comments

Comments
 (0)