Skip to content

Commit 4e8a47e

Browse files
Adam CohenAndroid Git Automerger
authored andcommitted
am 79e0f87: Merge "Fix small widgets not showing up on tablet (issue 7471516)" into jb-mr1-lockscreen-dev
* commit '79e0f875002d7bde5cf71053f9e9f054e9b5ffa2': Fix small widgets not showing up on tablet (issue 7471516)
2 parents 0ca353f + 79e0f87 commit 4e8a47e

File tree

6 files changed

+19
-0
lines changed

6 files changed

+19
-0
lines changed

core/res/res/values-sw600dp/bools.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,5 @@
2121
<bool name="kg_sim_puk_account_full_screen">false</bool>
2222
<!-- No camera for you, tablet user -->
2323
<bool name="kg_enable_camera_default_widget">false</bool>
24+
<bool name="kg_center_small_widgets_vertically">true</bool>
2425
</resources>

core/res/res/values/bools.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
<resources>
1818
<bool name="kg_enable_camera_default_widget">true</bool>
19+
<bool name="kg_center_small_widgets_vertically">false</bool>
1920
<bool name="action_bar_embed_tabs">true</bool>
2021
<bool name="action_bar_embed_tabs_pre_jb">false</bool>
2122
<bool name="split_action_bar_is_narrow">true</bool>

core/res/res/values/dimens.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -335,4 +335,9 @@
335335
due to the appearance of the IME), then drop the multiuser selector. -->
336336
<dimen name="kg_squashed_layout_threshold">600dp</dimen>
337337

338+
<!-- The height of widgets which do not support vertical resizing. This is only
339+
used on tablets; on phones, this size is determined by the space left by the
340+
security mode. -->
341+
<dimen name="kg_small_widget_height">160dp</dimen>
342+
338343
</resources>

core/res/res/values/symbols.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1216,6 +1216,7 @@
12161216
<java-symbol type="bool" name="kg_share_status_area" />
12171217
<java-symbol type="bool" name="kg_sim_puk_account_full_screen" />
12181218
<java-symbol type="bool" name="target_honeycomb_needs_options_menu" />
1219+
<java-symbol type="bool" name="kg_center_small_widgets_vertically" />
12191220
<java-symbol type="color" name="kg_multi_user_text_active" />
12201221
<java-symbol type="color" name="kg_multi_user_text_inactive" />
12211222
<java-symbol type="color" name="kg_widget_pager_gradient" />
@@ -1235,6 +1236,7 @@
12351236
<java-symbol type="dimen" name="keyguard_avatar_frame_shadow_radius" />
12361237
<java-symbol type="dimen" name="kg_edge_swipe_region_size" />
12371238
<java-symbol type="dimen" name="kg_squashed_layout_threshold" />
1239+
<java-symbol type="dimen" name="kg_small_widget_height" />
12381240
<java-symbol type="drawable" name="ic_jog_dial_sound_off" />
12391241
<java-symbol type="drawable" name="ic_jog_dial_sound_on" />
12401242
<java-symbol type="drawable" name="ic_jog_dial_unlock" />

policy/src/com/android/internal/policy/impl/keyguard/KeyguardWidgetFrame.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,10 @@ public KeyguardWidgetFrame(Context context, AttributeSet attrs, int defStyle) {
112112

113113
mFrameStrokeAdjustment = (int) (2 * density);
114114

115+
// This will be overriden on phones based on the current security mode, however on tablets
116+
// we need to specify a height.
117+
mSmallWidgetHeight =
118+
res.getDimensionPixelSize(com.android.internal.R.dimen.kg_small_widget_height);
115119
mBackgroundDrawable = res.getDrawable(R.drawable.kg_bouncer_bg_white);
116120
mGradientColor = res.getColor(com.android.internal.R.color.kg_widget_pager_gradient);
117121
mGradientPaint.setXfermode(sAddBlendMode);

policy/src/com/android/internal/policy/impl/keyguard/KeyguardWidgetPager.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ public class KeyguardWidgetPager extends PagedView implements PagedView.PageSwit
6464

6565
private static final long CUSTOM_WIDGET_USER_ACTIVITY_TIMEOUT = 30000;
6666
private static final String TAG = "KeyguardWidgetPager";
67+
private boolean mCenterSmallWidgetsVertically;
6768

6869
private int mPage = 0;
6970
private Callbacks mCallbacks;
@@ -94,6 +95,8 @@ public KeyguardWidgetPager(Context context, AttributeSet attrs, int defStyle) {
9495

9596
Resources r = getResources();
9697
mCameraWidgetEnabled = r.getBoolean(R.bool.kg_enable_camera_default_widget);
98+
mCenterSmallWidgetsVertically =
99+
r.getBoolean(com.android.internal.R.bool.kg_center_small_widgets_vertically);
97100
mBackgroundWorkerThread = new HandlerThread("KeyguardWidgetPager Worker");
98101
mBackgroundWorkerThread.start();
99102
mBackgroundWorkerHandler = new Handler(mBackgroundWorkerThread.getLooper());
@@ -277,6 +280,9 @@ public void addWidget(View widget, int pageIndex) {
277280
} else {
278281
// Lock the widget to be small.
279282
frame.setWidgetLockedSmall(true);
283+
if (mCenterSmallWidgetsVertically) {
284+
lp.gravity = Gravity.CENTER;
285+
}
280286
}
281287
}
282288
} else {

0 commit comments

Comments
 (0)