Skip to content

Commit 4d6da86

Browse files
jsharkeyAndroid (Google) Code Review
authored andcommitted
Merge "Move away from deprecated NetworkInfo extra."
2 parents 7a41c70 + 5e61331 commit 4d6da86

File tree

5 files changed

+18
-11
lines changed

5 files changed

+18
-11
lines changed

core/java/android/webkit/Network.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,9 @@ public void onReceive(Context context, Intent intent) {
169169
if (!ConnectivityManager.CONNECTIVITY_ACTION.equals(intent.getAction()))
170170
return;
171171

172-
NetworkInfo info = (NetworkInfo)intent.getParcelableExtra(ConnectivityManager.EXTRA_NETWORK_INFO);
172+
final ConnectivityManager connManager = (ConnectivityManager) context
173+
.getSystemService(Context.CONNECTIVITY_SERVICE);
174+
final NetworkInfo info = connManager.getActiveNetworkInfo();
173175
if (info != null)
174176
mRoaming = info.isRoaming();
175177
};

core/tests/bandwidthtests/src/com/android/bandwidthtest/util/ConnectionUtil.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -146,10 +146,10 @@ public void onReceive(Context context, Intent intent) {
146146
Log.v("ConnectivityReceiver", "onReceive() called with " + intent);
147147
return;
148148
}
149-
if (intent.hasExtra(ConnectivityManager.EXTRA_NETWORK_INFO)) {
150-
mNetworkInfo = (NetworkInfo)
151-
intent.getParcelableExtra(ConnectivityManager.EXTRA_NETWORK_INFO);
152-
}
149+
150+
final ConnectivityManager connManager = (ConnectivityManager) context
151+
.getSystemService(Context.CONNECTIVITY_SERVICE);
152+
mNetworkInfo = connManager.getActiveNetworkInfo();
153153

154154
if (intent.hasExtra(ConnectivityManager.EXTRA_OTHER_NETWORK_INFO)) {
155155
mOtherNetworkInfo = (NetworkInfo)

packages/SystemUI/src/com/android/systemui/statusbar/policy/NetworkController.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -850,8 +850,10 @@ private void updateConnectivity(Intent intent) {
850850
Slog.d(TAG, "updateConnectivity: intent=" + intent);
851851
}
852852

853-
NetworkInfo info = (NetworkInfo)(intent.getParcelableExtra(
854-
ConnectivityManager.EXTRA_NETWORK_INFO));
853+
final ConnectivityManager connManager = (ConnectivityManager) mContext
854+
.getSystemService(Context.CONNECTIVITY_SERVICE);
855+
final NetworkInfo info = connManager.getActiveNetworkInfo();
856+
855857
int connectionStatus = intent.getIntExtra(ConnectivityManager.EXTRA_INET_CONDITION, 0);
856858

857859
if (CHATTY) {

services/java/com/android/server/LocationManagerService.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1962,8 +1962,10 @@ public void onReceive(Context context, Intent intent) {
19621962
} else {
19631963
mNetworkState = LocationProvider.TEMPORARILY_UNAVAILABLE;
19641964
}
1965-
NetworkInfo info =
1966-
(NetworkInfo)intent.getExtra(ConnectivityManager.EXTRA_NETWORK_INFO);
1965+
1966+
final ConnectivityManager connManager = (ConnectivityManager) context
1967+
.getSystemService(Context.CONNECTIVITY_SERVICE);
1968+
final NetworkInfo info = connManager.getActiveNetworkInfo();
19671969

19681970
// Notify location providers of current network state
19691971
synchronized (mLock) {

services/java/com/android/server/NetworkTimeUpdateService.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -234,8 +234,9 @@ public void onReceive(Context context, Intent intent) {
234234
String action = intent.getAction();
235235
if (ConnectivityManager.CONNECTIVITY_ACTION.equals(action)) {
236236
// There is connectivity
237-
NetworkInfo netInfo = (NetworkInfo)intent.getParcelableExtra(
238-
ConnectivityManager.EXTRA_NETWORK_INFO);
237+
final ConnectivityManager connManager = (ConnectivityManager) context
238+
.getSystemService(Context.CONNECTIVITY_SERVICE);
239+
final NetworkInfo netInfo = connManager.getActiveNetworkInfo();
239240
if (netInfo != null) {
240241
// Verify that it's a WIFI connection
241242
if (netInfo.getState() == NetworkInfo.State.CONNECTED &&

0 commit comments

Comments
 (0)