Skip to content

Commit 49a13f0

Browse files
Steve BlockAndroid (Google) Code Review
authored andcommitted
Merge "Remove some stale TODOs from the Java Bridge tests"
2 parents 0b3caa4 + c93643b commit 49a13f0

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

tests/WebViewTests/src/com/android/webviewtests/JavaBridgeCoercionTest.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ private class TestObject extends Controller {
4747
private long mLongValue;
4848
private float mFloatValue;
4949
private double mDoubleValue;
50-
// TODO: Test passing to methods with array parameters.
5150
private String mStringValue;
5251
private Object mObjectValue;
5352
private CustomType mCustomTypeValue;
@@ -100,7 +99,6 @@ public synchronized void setDoubleValue(double x) {
10099
mDoubleValue = x;
101100
notifyResultIsReady();
102101
}
103-
// TODO: Test passing to methods with array parameters.
104102
public synchronized void setStringValue(String x) {
105103
mStringValue = x;
106104
notifyResultIsReady();
@@ -146,7 +144,6 @@ public synchronized double waitForDoubleValue() {
146144
waitForResult();
147145
return mDoubleValue;
148146
}
149-
// TODO: Test passing to methods with array parameters.
150147
public synchronized String waitForStringValue() {
151148
waitForResult();
152149
return mStringValue;
@@ -472,8 +469,6 @@ public void testPassString() throws Throwable {
472469
assertNull(mTestObject.waitForCustomTypeValue());
473470
}
474471

475-
// TODO: Test passing arrays.
476-
477472
// Test passing a JavaScript object to a method of an injected object.
478473
public void testPassJavaScriptObject() throws Throwable {
479474
// LIVECONNECT_COMPLIANCE: Should raise a JavaScript exception.

0 commit comments

Comments
 (0)