Skip to content

Commit 48994ce

Browse files
Jim MillerAndroid (Google) Code Review
authored andcommitted
Merge "Fix missing layout parameters in keyguard." into jb-mr1-dev
2 parents de5c3a0 + bdffd5c commit 48994ce

File tree

8 files changed

+12
-3
lines changed

8 files changed

+12
-3
lines changed

core/res/res/layout-port/keyguard_host_view.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@
3333

3434
<com.android.internal.policy.impl.keyguard.KeyguardSecurityViewFlipper
3535
android:id="@+id/view_flipper"
36-
android:layout_height="0dp"
36+
android:layout_width="match_parent"
37+
android:layout_height="0dip"
3738
android:clipChildren="false"
3839
android:clipToPadding="false"
3940
android:layout_weight="1"

core/res/res/layout-port/keyguard_status_area.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@
4545

4646
<TextView
4747
android:id="@+id/alarm_status"
48+
android:layout_width="wrap_content"
49+
android:layout_height="wrap_content"
4850
android:layout_marginEnd="@dimen/kg_status_line_font_right_margin"
4951
android:singleLine="true"
5052
android:ellipsize="marquee"
@@ -93,4 +95,4 @@
9395
android:textSize="@dimen/kg_status_line_font_size"
9496
/>
9597

96-
</LinearLayout>
98+
</LinearLayout>

core/res/res/layout-sw600dp-port/keyguard_status_area.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,4 +78,4 @@
7878
android:textAppearance="?android:attr/textAppearance"
7979
android:textSize="@dimen/kg_status_line_font_size"
8080
/>
81-
</LinearLayout>
81+
</LinearLayout>

core/res/res/layout/default_navigation.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818
-->
1919
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
2020
android:id="@+id/keyguard_click_area"
21+
android:layout_width="wrap_content"
22+
android:layout_height="wrap_content"
2123
android:gravity="center">
2224

2325
<!-- message area for security screen -->

core/res/res/layout/keyguard_password_view.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@
5353
since the backspace/IME switcher looks better inside -->
5454
<LinearLayout
5555
android:layout_gravity="center_vertical|fill_horizontal"
56+
android:layout_height="wrap_content"
5657
android:layout_width="match_parent"
5758
android:orientation="horizontal"
5859
android:background="#70000000"

core/res/res/layout/keyguard_sim_pin_view.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@
9191
<!-- Numeric keyboard -->
9292
<com.android.internal.widget.PasswordEntryKeyboardView android:id="@+id/keyboard"
9393
android:layout_width="match_parent"
94+
android:layout_height="wrap_content"
9495
android:layout_marginStart="4dip"
9596
android:layout_marginEnd="4dip"
9697
android:paddingTop="4dip"

core/res/res/layout/keyguard_sim_puk_view.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@
9393
<!-- Numeric keyboard -->
9494
<com.android.internal.widget.PasswordEntryKeyboardView android:id="@+id/keyboard"
9595
android:layout_width="match_parent"
96+
android:layout_height="wrap_content"
9697
android:layout_marginStart="4dip"
9798
android:layout_marginEnd="4dip"
9899
android:paddingTop="4dip"

policy/src/com/android/internal/policy/impl/keyguard/KeyguardHostView.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -611,6 +611,7 @@ private KeyguardSecurityView getSecurityView(SecurityMode securityMode) {
611611
int layoutId = getLayoutIdFor(securityMode);
612612
if (view == null && layoutId != 0) {
613613
final LayoutInflater inflater = LayoutInflater.from(mContext);
614+
if (DEBUG) Log.v(TAG, "inflating id = " + layoutId);
614615
View v = inflater.inflate(layoutId, this, false);
615616
mSecurityViewContainer.addView(v);
616617
updateSecurityView(v);

0 commit comments

Comments
 (0)