Skip to content

Commit 48618c9

Browse files
chethaaseAndroid (Google) Code Review
authored andcommitted
Merge "Fix GL shader bugs" into jb-mr1-dev
2 parents cdf964e + 0990ffb commit 48618c9

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

libs/hwui/Program.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ void Program::setColor(const float r, const float g, const float b, const float
178178
void Program::use() {
179179
glUseProgram(mProgramId);
180180
if (texCoords >= 0 && !mHasSampler) {
181-
glUniform1i(getUniform("sampler"), 0);
181+
glUniform1i(getUniform("baseSampler"), 0);
182182
mHasSampler = true;
183183
}
184184
mUse = true;

libs/hwui/ProgramCache.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -294,8 +294,8 @@ const char* gFS_Main_BlendShaders_Modulate[6] = {
294294
";\n",
295295
";\n",
296296
// Modulate
297-
" * fragColor.a;\n",
298-
" * fragColor.a;\n",
297+
" * color.a;\n",
298+
" * color.a;\n",
299299
// Modulate with alpha 8 texture
300300
" * texture2D(baseSampler, outTexCoords).a;\n",
301301
" * pow(texture2D(baseSampler, outTexCoords).a, gamma);\n"
@@ -305,8 +305,8 @@ const char* gFS_Main_GradientShader_Modulate[6] = {
305305
" fragColor = gradientColor;\n",
306306
" fragColor = gradientColor;\n",
307307
// Modulate
308-
" fragColor = gradientColor * fragColor.a;\n",
309-
" fragColor = gradientColor * fragColor.a;\n",
308+
" fragColor = gradientColor * color.a;\n",
309+
" fragColor = gradientColor * color.a;\n",
310310
// Modulate with alpha 8 texture
311311
" fragColor = gradientColor * texture2D(baseSampler, outTexCoords).a;\n",
312312
" fragColor = gradientColor * pow(texture2D(baseSampler, outTexCoords).a, gamma);\n"
@@ -316,8 +316,8 @@ const char* gFS_Main_BitmapShader_Modulate[6] = {
316316
" fragColor = bitmapColor;\n",
317317
" fragColor = bitmapColor;\n",
318318
// Modulate
319-
" fragColor = bitmapColor * fragColor.a;\n",
320-
" fragColor = bitmapColor * fragColor.a;\n",
319+
" fragColor = bitmapColor * color.a;\n",
320+
" fragColor = bitmapColor * color.a;\n",
321321
// Modulate with alpha 8 texture
322322
" fragColor = bitmapColor * texture2D(baseSampler, outTexCoords).a;\n",
323323
" fragColor = bitmapColor * pow(texture2D(baseSampler, outTexCoords).a, gamma);\n"

0 commit comments

Comments
 (0)