Skip to content

Commit 47e4015

Browse files
jsharkeyAndroid (Google) Code Review
authored andcommitted
Merge "Avoid airplane mode labels when Wi-Fi enabled." into ics-mr1
2 parents 2f504d9 + ec9cc1b commit 47e4015

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

packages/SystemUI/src/com/android/systemui/statusbar/policy/NetworkController.java

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -898,7 +898,7 @@ void refreshViews() {
898898
combinedSignalIconId = mDataSignalIconId; // set by updateDataIcon()
899899
mContentDescriptionCombinedSignal = mContentDescriptionDataType;
900900
}
901-
901+
902902
if (mWifiConnected) {
903903
if (mWifiSsid == null) {
904904
label = context.getString(R.string.status_bar_settings_signal_meter_wifi_nossid);
@@ -932,19 +932,23 @@ void refreshViews() {
932932
mContentDescriptionCombinedSignal = mContext.getString(
933933
R.string.accessibility_bluetooth_tether);
934934
}
935-
935+
936936
if (mAirplaneMode &&
937937
(mServiceState == null || (!hasService() && !mServiceState.isEmergencyOnly()))) {
938938
// Only display the flight-mode icon if not in "emergency calls only" mode.
939-
label = context.getString(R.string.status_bar_settings_signal_meter_disconnected);
940-
mContentDescriptionCombinedSignal = mContentDescriptionPhoneSignal
941-
= mContext.getString(R.string.accessibility_airplane_mode);
942-
939+
943940
// look again; your radios are now airplanes
941+
mContentDescriptionPhoneSignal = mContext.getString(
942+
R.string.accessibility_airplane_mode);
944943
mPhoneSignalIconId = mDataSignalIconId = R.drawable.stat_sys_signal_flightmode;
945944
mDataTypeIconId = 0;
946945

947-
combinedSignalIconId = mDataSignalIconId;
946+
// combined values from connected wifi take precedence over airplane mode
947+
if (!mWifiConnected) {
948+
label = context.getString(R.string.status_bar_settings_signal_meter_disconnected);
949+
mContentDescriptionCombinedSignal = mContentDescriptionPhoneSignal;
950+
combinedSignalIconId = mDataSignalIconId;
951+
}
948952
}
949953
else if (!mDataConnected && !mWifiConnected && !mBluetoothTethered && !mWimaxConnected) {
950954
// pretty much totally disconnected

0 commit comments

Comments
 (0)