Fix overdraw debug on QCOM

Romain Guy · Romain Guy · commit 4285de3c8bc7 · 2012-09-23T14:46:35.000-07:00
Disable the use of the tiling extension when overdraw debug is
turned on.

Change-Id: Ib0a0b7d1998146aa0c7efef2d3822f9997efb123
diff --git a/libs/hwui/Caches.cpp b/libs/hwui/Caches.cpp
@@ -435,15 +435,13 @@ void Caches::resetScissor() {
 ///////////////////////////////////////////////////////////////////////////////
 
 void Caches::startTiling(GLuint x, GLuint y, GLuint width, GLuint height, bool opaque) {
-    if (extensions.hasTiledRendering()) {
-        glStartTilingQCOM(x, y, width, height,
-                (opaque ? GL_NONE : GL_COLOR_BUFFER_BIT0_QCOM) |
-                (debugOverdraw ? GL_STENCIL_BUFFER_BIT0_QCOM : 0));
+    if (extensions.hasTiledRendering() && !debugOverdraw) {
+        glStartTilingQCOM(x, y, width, height, (opaque ? GL_NONE : GL_COLOR_BUFFER_BIT0_QCOM));
     }
 }
 
 void Caches::endTiling() {
-    if (extensions.hasTiledRendering()) {
+    if (extensions.hasTiledRendering() && !debugOverdraw) {
         glEndTilingQCOM(GL_COLOR_BUFFER_BIT0_QCOM);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -435,15 +435,13 @@ void Caches::resetScissor() {`
`435`	`435`	`///////////////////////////////////////////////////////////////////////////////`
`436`	`436`
`437`	`437`	`void Caches::startTiling(GLuint x, GLuint y, GLuint width, GLuint height, bool opaque) {`
`438`		`- if (extensions.hasTiledRendering()) {`
`439`		`- glStartTilingQCOM(x, y, width, height,`
`440`		`- (opaque ? GL_NONE : GL_COLOR_BUFFER_BIT0_QCOM) \|`
`441`		`- (debugOverdraw ? GL_STENCIL_BUFFER_BIT0_QCOM : 0));`
	`438`	`+ if (extensions.hasTiledRendering() && !debugOverdraw) {`
	`439`	`+ glStartTilingQCOM(x, y, width, height, (opaque ? GL_NONE : GL_COLOR_BUFFER_BIT0_QCOM));`
`442`	`440`	`}`
`443`	`441`	`}`
`444`	`442`
`445`	`443`	`void Caches::endTiling() {`
`446`		`- if (extensions.hasTiledRendering()) {`
	`444`	`+ if (extensions.hasTiledRendering() && !debugOverdraw) {`
`447`	`445`	`glEndTilingQCOM(GL_COLOR_BUFFER_BIT0_QCOM);`
`448`	`446`	`}`
`449`	`447`	`}`