Skip to content

Commit 4050da7

Browse files
Adam CohenAndroid (Google) Code Review
authored andcommitted
Merge "Addressing a couple comments on previous CL" into jb-mr1-lockscreen-dev
2 parents 70aa528 + 5be14de commit 4050da7

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

policy/src/com/android/internal/policy/impl/keyguard/KeyguardWidgetFrame.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public class KeyguardWidgetFrame extends FrameLayout {
6262
private float mBackgroundAlphaMultiplier = 1.0f;
6363
private Drawable mBackgroundDrawable;
6464
private Rect mBackgroundRect = new Rect();
65-
private static int mSmallWidgetHeight;
65+
private int mSmallWidgetHeight;
6666

6767
// Multiple callers may try and adjust the alpha of the frame. When a caller shows
6868
// the outlines, we give that caller control, and nobody else can fade them out.

policy/src/com/android/internal/policy/impl/keyguard/SlidingChallengeLayout.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -702,11 +702,13 @@ protected void onMeasure(int widthSpec, int heightSpec) {
702702
} else if (lp.childType == LayoutParams.CHILD_TYPE_SCRIM) {
703703
setScrimView(child);
704704
}
705+
705706
if (child.getVisibility() == GONE) continue;
706707
}
707708

708-
// We want to measure the challenge view first, for various reasons that I'd rather
709-
// not get into here.
709+
// We want to measure the challenge view first, since the KeyguardWidgetPager
710+
// needs to do things its measure pass that are dependent on the challenge view
711+
// having been measured.
710712
if (mChallengeView != null) {
711713
measureChildWithMargins(mChallengeView, widthSpec, 0, heightSpec, 0);
712714
}

0 commit comments

Comments
 (0)