Skip to content

Commit 3efc794

Browse files
pixelflingerAndroid (Google) Code Review
authored andcommitted
Merge "fix logging of eglMakeCurrent() errors"
2 parents 2daf331 + ca07e34 commit 3efc794

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

core/java/android/view/HardwareRenderer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -810,9 +810,9 @@ int checkCurrent() {
810810
if (!mEglContext.equals(sEgl.eglGetCurrentContext()) ||
811811
!mEglSurface.equals(sEgl.eglGetCurrentSurface(EGL_DRAW))) {
812812
if (!sEgl.eglMakeCurrent(sEglDisplay, mEglSurface, mEglSurface, mEglContext)) {
813-
fallback(true);
814813
Log.e(LOG_TAG, "eglMakeCurrent failed " +
815814
GLUtils.getEGLErrorString(sEgl.eglGetError()));
815+
fallback(true);
816816
return SURFACE_STATE_ERROR;
817817
} else {
818818
return SURFACE_STATE_UPDATED;

opengl/libs/EGL/eglApi.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -675,6 +675,9 @@ EGLBoolean eglMakeCurrent( EGLDisplay dpy, EGLSurface draw,
675675
setGLHooksThreadSpecific(&gHooksNoContext);
676676
egl_tls_t::setContext(EGL_NO_CONTEXT);
677677
}
678+
} else {
679+
// this will LOGE the error
680+
result = setError(c->cnx->egl.eglGetError(), EGL_FALSE);
678681
}
679682
return result;
680683
}

0 commit comments

Comments
 (0)