Skip to content

Commit 3e7e7f0

Browse files
author
Jeff Brown
committed
Fix improper use of CloseGuard.
Change-Id: I37131a86e27a4be55956384a3566de9dcfd90fe5
1 parent 4fd42e5 commit 3e7e7f0

File tree

2 files changed

+18
-2
lines changed

2 files changed

+18
-2
lines changed

core/java/android/view/DisplayEventReceiver.java

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public DisplayEventReceiver(Looper looper) {
6666
@Override
6767
protected void finalize() throws Throwable {
6868
try {
69-
dispose();
69+
dispose(true);
7070
} finally {
7171
super.finalize();
7272
}
@@ -76,9 +76,17 @@ protected void finalize() throws Throwable {
7676
* Disposes the receiver.
7777
*/
7878
public void dispose() {
79+
dispose(false);
80+
}
81+
82+
private void dispose(boolean finalized) {
7983
if (mCloseGuard != null) {
84+
if (finalized) {
85+
mCloseGuard.warnIfOpen();
86+
}
8087
mCloseGuard.close();
8188
}
89+
8290
if (mReceiverPtr != 0) {
8391
nativeDispose(mReceiverPtr);
8492
mReceiverPtr = 0;

core/java/android/view/InputEventReceiver.java

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public InputEventReceiver(InputChannel inputChannel, Looper looper) {
7373
@Override
7474
protected void finalize() throws Throwable {
7575
try {
76-
dispose();
76+
dispose(true);
7777
} finally {
7878
super.finalize();
7979
}
@@ -83,9 +83,17 @@ protected void finalize() throws Throwable {
8383
* Disposes the receiver.
8484
*/
8585
public void dispose() {
86+
dispose(false);
87+
}
88+
89+
private void dispose(boolean finalized) {
8690
if (mCloseGuard != null) {
91+
if (finalized) {
92+
mCloseGuard.warnIfOpen();
93+
}
8794
mCloseGuard.close();
8895
}
96+
8997
if (mReceiverPtr != 0) {
9098
nativeDispose(mReceiverPtr);
9199
mReceiverPtr = 0;

0 commit comments

Comments
 (0)