Skip to content

Commit 3d33a63

Browse files
committed
Add restoreCallingIdentity under finally
Change-Id: I068b1a2fc93300aa9bd17da6933bc8c5f0a6b5e4
1 parent db831da commit 3d33a63

File tree

1 file changed

+14
-8
lines changed

1 file changed

+14
-8
lines changed

services/java/com/android/server/WifiService.java

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -640,8 +640,11 @@ public synchronized boolean setWifiEnabled(boolean enable) {
640640
*/
641641

642642
long ident = Binder.clearCallingIdentity();
643-
handleWifiToggled(enable);
644-
Binder.restoreCallingIdentity(ident);
643+
try {
644+
handleWifiToggled(enable);
645+
} finally {
646+
Binder.restoreCallingIdentity(ident);
647+
}
645648

646649
if (enable) {
647650
if (!mIsReceiverRegistered) {
@@ -838,12 +841,15 @@ public List<ScanResult> getScanResults() {
838841
enforceAccessPermission();
839842
int userId = UserHandle.getCallingUserId();
840843
long ident = Binder.clearCallingIdentity();
841-
int currentUser = ActivityManager.getCurrentUser();
842-
Binder.restoreCallingIdentity(ident);
843-
if (userId != currentUser) {
844-
return new ArrayList<ScanResult>();
845-
} else {
846-
return mWifiStateMachine.syncGetScanResultsList();
844+
try {
845+
int currentUser = ActivityManager.getCurrentUser();
846+
if (userId != currentUser) {
847+
return new ArrayList<ScanResult>();
848+
} else {
849+
return mWifiStateMachine.syncGetScanResultsList();
850+
}
851+
} finally {
852+
Binder.restoreCallingIdentity(ident);
847853
}
848854
}
849855

0 commit comments

Comments
 (0)