Skip to content

Commit 3d0083b

Browse files
author
Jim Miller
committed
Fix 6539117: Fix layout issues on 600dp device.
This fixes two issues: 1. The pattern view was shown too low on the device due to shared layout with 720dp device. 2. The time was showing on top of the transport control view (music playback widget) Change-Id: Id8a5809f96cfbda7eb55fa91b1bea826d483373a
1 parent 2bccea2 commit 3d0083b

File tree

2 files changed

+20
-24
lines changed

2 files changed

+20
-24
lines changed

core/res/res/layout-sw600dp/keyguard_screen_unlock_landscape.xml

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,16 @@
3939
android:layout_height="wrap_content"
4040
android:layout_marginBottom="24dip">
4141

42-
<!-- Music transport control underneath -->
42+
<include layout="@layout/keyguard_screen_status_land"
43+
android:layout_width="match_parent"
44+
android:layout_height="wrap_content"
45+
android:layout_marginLeft="50dip"
46+
android:layout_marginTop="50dip"
47+
android:layout_marginBottom="50dip"
48+
android:layout_marginRight="64dip"
49+
android:layout_alignParentTop="true"
50+
android:layout_alignParentLeft="true"/>
51+
4352
<include android:id="@+id/transport"
4453
layout="@layout/keyguard_transport_control"
4554
android:layout_row="0"
@@ -51,16 +60,6 @@
5160
android:layout_height="512dip"
5261
/>
5362

54-
<include layout="@layout/keyguard_screen_status_land"
55-
android:layout_width="match_parent"
56-
android:layout_height="wrap_content"
57-
android:layout_marginLeft="50dip"
58-
android:layout_marginTop="50dip"
59-
android:layout_marginBottom="50dip"
60-
android:layout_marginRight="64dip"
61-
android:layout_alignParentTop="true"
62-
android:layout_alignParentLeft="true"/>
63-
6463
</RelativeLayout>
6564

6665
</RelativeLayout>

core/res/res/layout-sw600dp/keyguard_screen_unlock_portrait.xml

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
<!-- top: status -->
2727
<RelativeLayout
2828
android:layout_height="0dip"
29-
android:layout_weight="1"
29+
android:layout_weight="0.40"
3030
android:layout_width="match_parent"
3131
android:gravity="center">
3232

@@ -35,6 +35,14 @@
3535
android:layout_height="wrap_content"
3636
android:gravity="center">
3737

38+
<include layout="@layout/keyguard_screen_status_land"
39+
android:layout_width="wrap_content"
40+
android:layout_height="wrap_content"
41+
android:layout_marginLeft="50dip"
42+
android:layout_marginTop="50dip"
43+
android:layout_alignParentTop="true"
44+
android:layout_alignParentLeft="true"/>
45+
3846
<!-- Music transport control -->
3947
<include android:id="@+id/transport"
4048
layout="@layout/keyguard_transport_control"
@@ -47,23 +55,13 @@
4755
android:layout_height="512dip"
4856
/>
4957

50-
<include layout="@layout/keyguard_screen_status_land"
51-
android:layout_width="wrap_content"
52-
android:layout_height="wrap_content"
53-
android:layout_marginLeft="50dip"
54-
android:layout_marginTop="50dip"
55-
android:layout_marginBottom="100dip"
56-
android:layout_marginRight="64dip"
57-
android:layout_alignParentTop="true"
58-
android:layout_alignParentLeft="true"/>
59-
6058
</RelativeLayout>
6159

6260
</RelativeLayout>
6361

6462
<!-- bottom: lock pattern, emergency dialer and forgot pattern button -->
6563
<RelativeLayout
66-
android:layout_weight="1"
64+
android:layout_weight="0.60"
6765
android:layout_width="match_parent"
6866
android:layout_height="0dip"
6967
android:gravity="center">
@@ -77,7 +75,6 @@
7775
<com.android.internal.widget.LockPatternView android:id="@+id/lockPattern"
7876
android:layout_width="354dip"
7977
android:layout_height="354dip"
80-
android:layout_marginTop="50dip"
8178
/>
8279

8380
<!-- Emergency and forgot pattern buttons. -->

0 commit comments

Comments
 (0)