Skip to content

Commit 3a8af8e

Browse files
jsharkeyAndroid (Google) Code Review
authored andcommitted
Merge "Migrate more Secure settings to Global." into jb-mr1-dev
2 parents 5e08af0 + 625239a commit 3a8af8e

File tree

21 files changed

+537
-372
lines changed

21 files changed

+537
-372
lines changed

api/current.txt

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18816,6 +18816,7 @@ package android.provider {
1881618816
field public static final java.lang.String DATA_ROAMING = "data_roaming";
1881718817
field public static final java.lang.String DEVELOPMENT_SETTINGS_ENABLED = "development_settings_enabled";
1881818818
field public static final java.lang.String DEVICE_PROVISIONED = "device_provisioned";
18819+
field public static final java.lang.String HTTP_PROXY = "http_proxy";
1881918820
field public static final java.lang.String INSTALL_NON_MARKET_APPS = "install_non_market_apps";
1882018821
field public static final java.lang.String MODE_RINGER = "mode_ringer";
1882118822
field public static final java.lang.String NETWORK_PREFERENCE = "network_preference";
@@ -18879,7 +18880,7 @@ package android.provider {
1887918880
field public static final deprecated java.lang.String DEVICE_PROVISIONED = "device_provisioned";
1888018881
field public static final java.lang.String ENABLED_ACCESSIBILITY_SERVICES = "enabled_accessibility_services";
1888118882
field public static final java.lang.String ENABLED_INPUT_METHODS = "enabled_input_methods";
18882-
field public static final java.lang.String HTTP_PROXY = "http_proxy";
18883+
field public static final deprecated java.lang.String HTTP_PROXY = "http_proxy";
1888318884
field public static final java.lang.String INPUT_METHOD_SELECTOR_VISIBILITY = "input_method_selector_visibility";
1888418885
field public static final deprecated java.lang.String INSTALL_NON_MARKET_APPS = "install_non_market_apps";
1888518886
field public static final java.lang.String LOCATION_PROVIDERS_ALLOWED = "location_providers_allowed";
@@ -19038,12 +19039,12 @@ package android.provider {
1903819039
field public static final deprecated int WIFI_SLEEP_POLICY_DEFAULT = 0; // 0x0
1903919040
field public static final deprecated int WIFI_SLEEP_POLICY_NEVER = 2; // 0x2
1904019041
field public static final deprecated int WIFI_SLEEP_POLICY_NEVER_WHILE_PLUGGED = 1; // 0x1
19041-
field public static final java.lang.String WIFI_STATIC_DNS1 = "wifi_static_dns1";
19042-
field public static final java.lang.String WIFI_STATIC_DNS2 = "wifi_static_dns2";
19043-
field public static final java.lang.String WIFI_STATIC_GATEWAY = "wifi_static_gateway";
19044-
field public static final java.lang.String WIFI_STATIC_IP = "wifi_static_ip";
19045-
field public static final java.lang.String WIFI_STATIC_NETMASK = "wifi_static_netmask";
19046-
field public static final java.lang.String WIFI_USE_STATIC_IP = "wifi_use_static_ip";
19042+
field public static final deprecated java.lang.String WIFI_STATIC_DNS1 = "wifi_static_dns1";
19043+
field public static final deprecated java.lang.String WIFI_STATIC_DNS2 = "wifi_static_dns2";
19044+
field public static final deprecated java.lang.String WIFI_STATIC_GATEWAY = "wifi_static_gateway";
19045+
field public static final deprecated java.lang.String WIFI_STATIC_IP = "wifi_static_ip";
19046+
field public static final deprecated java.lang.String WIFI_STATIC_NETMASK = "wifi_static_netmask";
19047+
field public static final deprecated java.lang.String WIFI_USE_STATIC_IP = "wifi_use_static_ip";
1904719048
field public static final deprecated java.lang.String WIFI_WATCHDOG_ACCEPTABLE_PACKET_LOSS_PERCENTAGE = "wifi_watchdog_acceptable_packet_loss_percentage";
1904819049
field public static final deprecated java.lang.String WIFI_WATCHDOG_AP_COUNT = "wifi_watchdog_ap_count";
1904919050
field public static final deprecated java.lang.String WIFI_WATCHDOG_BACKGROUND_CHECK_DELAY_MS = "wifi_watchdog_background_check_delay_ms";

core/java/android/app/ApplicationErrorReport.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,8 +158,8 @@ public ApplicationErrorReport() {
158158
public static ComponentName getErrorReportReceiver(Context context,
159159
String packageName, int appFlags) {
160160
// check if error reporting is enabled in secure settings
161-
int enabled = Settings.Secure.getInt(context.getContentResolver(),
162-
Settings.Secure.SEND_ACTION_APP_ERROR, 0);
161+
int enabled = Settings.Global.getInt(context.getContentResolver(),
162+
Settings.Global.SEND_ACTION_APP_ERROR, 0);
163163
if (enabled == 0) {
164164
return null;
165165
}

core/java/android/content/SyncManager.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -777,8 +777,8 @@ private void increaseBackoffSetting(SyncOperation op) {
777777
}
778778

779779
// Cap the delay
780-
long maxSyncRetryTimeInSeconds = Settings.Secure.getLong(mContext.getContentResolver(),
781-
Settings.Secure.SYNC_MAX_RETRY_DELAY_IN_SECONDS,
780+
long maxSyncRetryTimeInSeconds = Settings.Global.getLong(mContext.getContentResolver(),
781+
Settings.Global.SYNC_MAX_RETRY_DELAY_IN_SECONDS,
782782
DEFAULT_MAX_SYNC_RETRY_TIME_IN_SECONDS);
783783
if (newDelayInMs > maxSyncRetryTimeInSeconds * 1000) {
784784
newDelayInMs = maxSyncRetryTimeInSeconds * 1000;

core/java/android/net/CaptivePortalTracker.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -89,12 +89,12 @@ private CaptivePortalTracker(Context context, IConnectivityManager cs) {
8989
filter.addAction(ConnectivityManager.CONNECTIVITY_ACTION);
9090
mContext.registerReceiver(mReceiver, filter);
9191

92-
mServer = Settings.Secure.getString(mContext.getContentResolver(),
93-
Settings.Secure.CAPTIVE_PORTAL_SERVER);
92+
mServer = Settings.Global.getString(mContext.getContentResolver(),
93+
Settings.Global.CAPTIVE_PORTAL_SERVER);
9494
if (mServer == null) mServer = DEFAULT_SERVER;
9595

96-
mIsCaptivePortalCheckEnabled = Settings.Secure.getInt(mContext.getContentResolver(),
97-
Settings.Secure.CAPTIVE_PORTAL_DETECTION_ENABLED, 1) == 1;
96+
mIsCaptivePortalCheckEnabled = Settings.Global.getInt(mContext.getContentResolver(),
97+
Settings.Global.CAPTIVE_PORTAL_DETECTION_ENABLED, 1) == 1;
9898

9999
addState(mDefaultState);
100100
addState(mNoActiveNetworkState, mDefaultState);

core/java/android/net/ConnectivityManager.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -330,6 +330,14 @@ public class ConnectivityManager {
330330

331331
public static final int DEFAULT_NETWORK_PREFERENCE = TYPE_WIFI;
332332

333+
/**
334+
* Default value for {@link Settings.Global#CONNECTIVITY_CHANGE_DELAY} in
335+
* milliseconds.
336+
*
337+
* @hide
338+
*/
339+
public static final int CONNECTIVITY_CHANGE_DELAY_DEFAULT = 3000;
340+
333341
private final IConnectivityManager mService;
334342

335343
public static boolean isNetworkTypeValid(int networkType) {

core/java/android/net/DnsPinger.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -295,8 +295,8 @@ private LinkProperties getCurrentLinkProperties() {
295295
}
296296

297297
private InetAddress getDefaultDns() {
298-
String dns = Settings.Secure.getString(mContext.getContentResolver(),
299-
Settings.Secure.DEFAULT_DNS_SERVER);
298+
String dns = Settings.Global.getString(mContext.getContentResolver(),
299+
Settings.Global.DEFAULT_DNS_SERVER);
300300
if (dns == null || dns.length() == 0) {
301301
dns = mContext.getResources().getString(
302302
com.android.internal.R.string.config_default_dns_server);

0 commit comments

Comments
 (0)