Skip to content

Commit 38f1978

Browse files
Jean-Baptiste QueruAndroid Git Automerger
authored andcommitted
am 14c0c98: am 4ba4cae: Merge "Fix SkBitmap::fPixels not being locked correctly"
* commit '14c0c989d21531056a5d0a0739c3ffdd1b04b295': Fix SkBitmap::fPixels not being locked correctly
2 parents c88a80a + 14c0c98 commit 38f1978

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

core/jni/android/graphics/Bitmap.cpp

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -298,8 +298,18 @@ static bool Bitmap_compress(JNIEnv* env, jobject clazz, SkBitmap* bitmap,
298298
}
299299

300300
bool success = false;
301-
SkWStream* strm = CreateJavaOutputStreamAdaptor(env, jstream, jstorage);
302-
if (NULL != strm) {
301+
if (NULL != bitmap) {
302+
SkAutoLockPixels alp(*bitmap);
303+
304+
if (NULL == bitmap->getPixels()) {
305+
return false;
306+
}
307+
308+
SkWStream* strm = CreateJavaOutputStreamAdaptor(env, jstream, jstorage);
309+
if (NULL == strm) {
310+
return false;
311+
}
312+
303313
SkImageEncoder* encoder = SkImageEncoder::Create(fm);
304314
if (NULL != encoder) {
305315
success = encoder->encodeStream(strm, *bitmap, quality);

0 commit comments

Comments
 (0)