Skip to content

Commit 374d243

Browse files
George MountAndroid (Google) Code Review
authored andcommitted
Merge "Disable selection when nothing selected."
2 parents 4abe548 + 9a6077e commit 374d243

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

core/java/android/webkit/WebView.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9522,10 +9522,11 @@ private void updateTextSelectionFromMessage(int nodePointer,
95229522
}
95239523
}
95249524
nativeSetTextSelection(mNativeClass, data.mSelectTextPtr);
9525-
if (data.mSelectTextPtr != 0) {
9526-
mIsCaretSelection = (mFieldPointer == nodePointer)
9527-
&& (mFieldPointer != 0)
9528-
&& (data.mStart == data.mEnd);
9525+
9526+
if (data.mSelectTextPtr != 0 &&
9527+
(data.mStart != data.mEnd ||
9528+
(mFieldPointer == nodePointer && mFieldPointer != 0))) {
9529+
mIsCaretSelection = (data.mStart == data.mEnd);
95299530
if (!mSelectingText) {
95309531
setupWebkitSelect();
95319532
} else if (!mSelectionStarted) {

0 commit comments

Comments
 (0)