Skip to content

Commit 3451dc9

Browse files
jsharkeyAndroid (Google) Code Review
authored andcommitted
Merge "Iteration on multi-user external storage." into jb-mr1-dev
2 parents 9f814ac + 2bca868 commit 3451dc9

File tree

3 files changed

+5
-14
lines changed

3 files changed

+5
-14
lines changed

core/java/android/os/Process.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -582,9 +582,7 @@ private static ProcessStartResult startViaZygote(final String processClass,
582582
if ((debugFlags & Zygote.DEBUG_ENABLE_ASSERT) != 0) {
583583
argsForZygote.add("--enable-assert");
584584
}
585-
if (mountExternal == Zygote.MOUNT_EXTERNAL_SINGLEUSER) {
586-
argsForZygote.add("--mount-external-singleuser");
587-
} else if (mountExternal == Zygote.MOUNT_EXTERNAL_MULTIUSER) {
585+
if (mountExternal == Zygote.MOUNT_EXTERNAL_MULTIUSER) {
588586
argsForZygote.add("--mount-external-multiuser");
589587
}
590588
argsForZygote.add("--target-sdk-version=" + targetSdkVersion);

core/java/com/android/internal/os/ZygoteConnection.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -527,8 +527,6 @@ private void parseArgs(String args[])
527527
"Duplicate arg specified");
528528
}
529529
niceName = arg.substring(arg.indexOf('=') + 1);
530-
} else if (arg.equals("--mount-external-singleuser")) {
531-
mountExternal = Zygote.MOUNT_EXTERNAL_SINGLEUSER;
532530
} else if (arg.equals("--mount-external-multiuser")) {
533531
mountExternal = Zygote.MOUNT_EXTERNAL_MULTIUSER;
534532
} else {

services/java/com/android/server/am/ActivityManagerService.java

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1983,18 +1983,13 @@ private final void startProcessLocked(ProcessRecord app,
19831983
try {
19841984
final PackageManager pm = mContext.getPackageManager();
19851985
gids = pm.getPackageGids(app.info.packageName);
1986-
if (pm.checkPermission(
1987-
android.Manifest.permission.READ_EXTERNAL_STORAGE, app.info.packageName)
1988-
== PERMISSION_GRANTED) {
1989-
if (Environment.isExternalStorageEmulated()) {
1990-
mountExternal = Zygote.MOUNT_EXTERNAL_MULTIUSER;
1991-
} else {
1992-
mountExternal = Zygote.MOUNT_EXTERNAL_SINGLEUSER;
1993-
}
1994-
}
19951986
} catch (PackageManager.NameNotFoundException e) {
19961987
Slog.w(TAG, "Unable to retrieve gids", e);
19971988
}
1989+
1990+
if (Environment.isExternalStorageEmulated()) {
1991+
mountExternal = Zygote.MOUNT_EXTERNAL_MULTIUSER;
1992+
}
19981993
}
19991994
if (mFactoryTest != SystemServer.FACTORY_TEST_OFF) {
20001995
if (mFactoryTest == SystemServer.FACTORY_TEST_LOW_LEVEL

0 commit comments

Comments
 (0)