Skip to content

Commit 33c5670

Browse files
enh-googleandroid code review
authored andcommitted
Merge "Fewer warnings in aidl generated code."
2 parents 9885362 + b327c41 commit 33c5670

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

tools/aidl/generate_java_binder.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ StubClass::StubClass(Type* type, Type* interfaceType)
5454

5555
// asBinder
5656
Method* asBinder = new Method;
57-
asBinder->modifiers = PUBLIC;
57+
asBinder->modifiers = PUBLIC | OVERRIDE;
5858
asBinder->returnType = IBINDER_TYPE;
5959
asBinder->name = "asBinder";
6060
asBinder->statements = new StatementBlock;
@@ -117,7 +117,7 @@ StubClass::make_as_interface(Type *interfaceType)
117117
queryLocalInterface->arguments.push_back(new LiteralExpression("DESCRIPTOR"));
118118
IInterfaceType* iinType = new IInterfaceType();
119119
Variable *iin = new Variable(iinType, "iin");
120-
VariableDeclaration* iinVd = new VariableDeclaration(iin, queryLocalInterface, iinType);
120+
VariableDeclaration* iinVd = new VariableDeclaration(iin, queryLocalInterface, NULL);
121121
m->statements->Add(iinVd);
122122

123123
// Ensure the instance type of the local object is as expected.
@@ -181,7 +181,7 @@ ProxyClass::ProxyClass(Type* type, InterfaceType* interfaceType)
181181

182182
// IBinder asBinder()
183183
Method* asBinder = new Method;
184-
asBinder->modifiers = PUBLIC;
184+
asBinder->modifiers = PUBLIC | OVERRIDE;
185185
asBinder->returnType = IBINDER_TYPE;
186186
asBinder->name = "asBinder";
187187
asBinder->statements = new StatementBlock;
@@ -384,7 +384,7 @@ generate_method(const method_type* method, Class* interface,
384384
// == the proxy method ===================================================
385385
Method* proxy = new Method;
386386
proxy->comment = gather_comments(method->comments_token->extra);
387-
proxy->modifiers = PUBLIC;
387+
proxy->modifiers = PUBLIC | OVERRIDE;
388388
proxy->returnType = NAMES.Search(method->type.type.data);
389389
proxy->returnTypeDimension = method->type.dimension;
390390
proxy->name = method->name.data;

0 commit comments

Comments
 (0)