Skip to content

Commit 2f36229

Browse files
committed
Use Map.Entry, not HashMap.Entry
Map.Entry is the defined return value from entrySet(). HashMap.Entry shouldn't be used directly. Change-Id: Ia21598c6a73fe7eb22179ce114095f779c903084
1 parent c79e413 commit 2f36229

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

core/java/android/accounts/AccountManagerService.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@
6262
import java.util.Collection;
6363
import java.util.HashMap;
6464
import java.util.LinkedHashMap;
65+
import java.util.Map;
6566
import java.util.concurrent.atomic.AtomicInteger;
6667
import java.util.concurrent.atomic.AtomicReference;
6768

@@ -275,7 +276,7 @@ private void validateAccountsAndPopulateCache() {
275276
accountNames.add(accountName);
276277
}
277278
}
278-
for (HashMap.Entry<String, ArrayList<String>> cur
279+
for (Map.Entry<String, ArrayList<String>> cur
279280
: accountNamesByType.entrySet()) {
280281
final String accountType = cur.getKey();
281282
final ArrayList<String> accountNames = cur.getValue();

services/java/com/android/server/pm/PackageManagerService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -620,11 +620,11 @@ void doHandleMessage(Message msg) {
620620
packages = new String[size];
621621
components = new ArrayList[size];
622622
uids = new int[size];
623-
Iterator<HashMap.Entry<String, ArrayList<String>>>
623+
Iterator<Map.Entry<String, ArrayList<String>>>
624624
it = mPendingBroadcasts.entrySet().iterator();
625625
int i = 0;
626626
while (it.hasNext() && i < size) {
627-
HashMap.Entry<String, ArrayList<String>> ent = it.next();
627+
Map.Entry<String, ArrayList<String>> ent = it.next();
628628
packages[i] = ent.getKey();
629629
components[i] = ent.getValue();
630630
PackageSetting ps = mSettings.mPackages.get(ent.getKey());

services/java/com/android/server/pm/Settings.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@
6262
import java.util.HashMap;
6363
import java.util.HashSet;
6464
import java.util.Iterator;
65+
import java.util.Map;
6566

6667
import libcore.io.IoUtils;
6768

@@ -929,7 +930,7 @@ void writeLPr() {
929930
}
930931

931932
if (mRenamedPackages.size() > 0) {
932-
for (HashMap.Entry<String, String> e : mRenamedPackages.entrySet()) {
933+
for (Map.Entry<String, String> e : mRenamedPackages.entrySet()) {
933934
serializer.startTag(null, "renamed-package");
934935
serializer.attribute(null, "new", e.getKey());
935936
serializer.attribute(null, "old", e.getValue());
@@ -2144,7 +2145,7 @@ void dumpPackagesLPr(PrintWriter pw, String packageName, DumpState dumpState) {
21442145

21452146
printedSomething = false;
21462147
if (mRenamedPackages.size() > 0) {
2147-
for (final HashMap.Entry<String, String> e : mRenamedPackages.entrySet()) {
2148+
for (final Map.Entry<String, String> e : mRenamedPackages.entrySet()) {
21482149
if (packageName != null && !packageName.equals(e.getKey())
21492150
&& !packageName.equals(e.getValue())) {
21502151
continue;
@@ -2258,4 +2259,4 @@ void dumpReadMessagesLPr(PrintWriter pw, DumpState dumpState) {
22582259
pw.println("Settings parse messages:");
22592260
pw.print(mReadMessages.toString());
22602261
}
2261-
}
2262+
}

0 commit comments

Comments
 (0)