Skip to content

Commit 2f09576

Browse files
author
Jeff Brown
committed
Rename kcm attribute to keyboardLayout.
Bug: 6478076 Change-Id: I7fc0d8eb36d03a628d070f8fd6ea1e1464b1a163
1 parent 3816174 commit 2f09576

File tree

7 files changed

+44
-43
lines changed

7 files changed

+44
-43
lines changed

api/16.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -593,7 +593,6 @@ package android {
593593
field public static final int itemIconDisabledAlpha = 16843057; // 0x1010131
594594
field public static final int itemPadding = 16843565; // 0x101032d
595595
field public static final int itemTextAppearance = 16843052; // 0x101012c
596-
field public static final int kcm = 16843691; // 0x10103ab
597596
field public static final int keepScreenOn = 16843286; // 0x1010216
598597
field public static final int key = 16843240; // 0x10101e8
599598
field public static final int keyBackground = 16843315; // 0x1010233
@@ -608,6 +607,7 @@ package android {
608607
field public static final int keyTextColor = 16843318; // 0x1010236
609608
field public static final int keyTextSize = 16843316; // 0x1010234
610609
field public static final int keyWidth = 16843325; // 0x101023d
610+
field public static final int keyboardLayout = 16843691; // 0x10103ab
611611
field public static final int keyboardMode = 16843341; // 0x101024d
612612
field public static final int keycode = 16842949; // 0x10100c5
613613
field public static final int killAfterRestore = 16843420; // 0x101029c

api/current.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -594,7 +594,6 @@ package android {
594594
field public static final int itemIconDisabledAlpha = 16843057; // 0x1010131
595595
field public static final int itemPadding = 16843565; // 0x101032d
596596
field public static final int itemTextAppearance = 16843052; // 0x101012c
597-
field public static final int kcm = 16843691; // 0x10103ab
598597
field public static final int keepScreenOn = 16843286; // 0x1010216
599598
field public static final int key = 16843240; // 0x10101e8
600599
field public static final int keyBackground = 16843315; // 0x1010233
@@ -609,6 +608,7 @@ package android {
609608
field public static final int keyTextColor = 16843318; // 0x1010236
610609
field public static final int keyTextSize = 16843316; // 0x1010234
611610
field public static final int keyWidth = 16843325; // 0x101023d
611+
field public static final int keyboardLayout = 16843691; // 0x10103ab
612612
field public static final int keyboardMode = 16843341; // 0x101024d
613613
field public static final int keycode = 16842949; // 0x10100c5
614614
field public static final int killAfterRestore = 16843420; // 0x101029c

core/java/android/hardware/input/InputManager.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,14 +96,14 @@ public final class InputManager {
9696
* <keyboard-layouts xmlns:android="http://schemas.android.com/apk/res/android">
9797
* <keyboard-layout android:name="keyboard_layout_english_us"
9898
* android:label="@string/keyboard_layout_english_us_label"
99-
* android:kcm="@raw/keyboard_layout_english_us" />
99+
* android:keyboardLayout="@raw/keyboard_layout_english_us" />
100100
* </keyboard-layouts>
101101
* </p><p>
102102
* The <code>android:name</code> attribute specifies an identifier by which
103103
* the keyboard layout will be known in the package.
104104
* The <code>android:label</code> attributes specifies a human-readable descriptive
105105
* label to describe the keyboard layout in the user interface, such as "English (US)".
106-
* The <code>android:kcm</code> attribute refers to a
106+
* The <code>android:keyboardLayout</code> attribute refers to a
107107
* <a href="http://source.android.com/tech/input/key-character-map-files.html">
108108
* key character map</a> resource that defines the keyboard layout.
109109
* </p>

core/res/res/values/attrs.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5627,6 +5627,6 @@
56275627
<!-- The display label of the keyboard layout. -->
56285628
<attr name="label" />
56295629
<!-- The key character map file resource. -->
5630-
<attr name="kcm" format="reference" />
5630+
<attr name="keyboardLayout" format="reference" />
56315631
</declare-styleable>
56325632
</resources>

core/res/res/values/public.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3603,7 +3603,7 @@
36033603
<public type="attr" name="permissionGroupFlags" id="0x010103a8" />
36043604
<public type="attr" name="isolatedProcess" id="0x010103a9" />
36053605
<public type="attr" name="importantForAccessibility" id="0x010103aa" />
3606-
<public type="attr" name="kcm" id="0x010103ab" />
3606+
<public type="attr" name="keyboardLayout" id="0x010103ab" />
36073607
<public type="attr" name="fontFamily" id="0x010103ac" />
36083608

36093609
</resources>

packages/InputDevices/res/xml/keyboard_layouts.xml

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -2,109 +2,109 @@
22
<keyboard-layouts xmlns:android="http://schemas.android.com/apk/res/android">
33
<keyboard-layout android:name="keyboard_layout_english_us"
44
android:label="@string/keyboard_layout_english_us_label"
5-
android:kcm="@raw/keyboard_layout_english_us" />
5+
android:keyboardLayout="@raw/keyboard_layout_english_us" />
66

77
<keyboard-layout android:name="keyboard_layout_english_us_dvorak"
88
android:label="@string/keyboard_layout_english_us_dvorak_label"
9-
android:kcm="@raw/keyboard_layout_english_us_dvorak" />
9+
android:keyboardLayout="@raw/keyboard_layout_english_us_dvorak" />
1010

1111
<keyboard-layout android:name="keyboard_layout_german"
1212
android:label="@string/keyboard_layout_german_label"
13-
android:kcm="@raw/keyboard_layout_german" />
13+
android:keyboardLayout="@raw/keyboard_layout_german" />
1414

1515
<keyboard-layout android:name="keyboard_layout_french"
1616
android:label="@string/keyboard_layout_french_label"
17-
android:kcm="@raw/keyboard_layout_french" />
17+
android:keyboardLayout="@raw/keyboard_layout_french" />
1818

1919
<keyboard-layout android:name="keyboard_layout_french_ca"
2020
android:label="@string/keyboard_layout_french_ca_label"
21-
android:kcm="@raw/keyboard_layout_french_ca" />
21+
android:keyboardLayout="@raw/keyboard_layout_french_ca" />
2222

2323
<keyboard-layout android:name="keyboard_layout_russian"
2424
android:label="@string/keyboard_layout_russian_label"
25-
android:kcm="@raw/keyboard_layout_russian" />
25+
android:keyboardLayout="@raw/keyboard_layout_russian" />
2626

2727
<keyboard-layout android:name="keyboard_layout_russian_mac"
2828
android:label="@string/keyboard_layout_russian_mac_label"
29-
android:kcm="@raw/keyboard_layout_russian_mac" />
29+
android:keyboardLayout="@raw/keyboard_layout_russian_mac" />
3030

3131
<keyboard-layout android:name="keyboard_layout_spanish"
3232
android:label="@string/keyboard_layout_spanish_label"
33-
android:kcm="@raw/keyboard_layout_spanish" />
33+
android:keyboardLayout="@raw/keyboard_layout_spanish" />
3434

3535
<keyboard-layout android:name="keyboard_layout_swiss_french"
3636
android:label="@string/keyboard_layout_swiss_french_label"
37-
android:kcm="@raw/keyboard_layout_swiss_french" />
37+
android:keyboardLayout="@raw/keyboard_layout_swiss_french" />
3838

3939
<keyboard-layout android:name="keyboard_layout_swiss_german"
4040
android:label="@string/keyboard_layout_swiss_german_label"
41-
android:kcm="@raw/keyboard_layout_swiss_german" />
41+
android:keyboardLayout="@raw/keyboard_layout_swiss_german" />
4242

4343
<keyboard-layout android:name="keyboard_layout_belgian"
4444
android:label="@string/keyboard_layout_belgian"
45-
android:kcm="@raw/keyboard_layout_belgian" />
45+
android:keyboardLayout="@raw/keyboard_layout_belgian" />
4646

4747
<keyboard-layout android:name="keyboard_layout_bulgarian"
4848
android:label="@string/keyboard_layout_bulgarian"
49-
android:kcm="@raw/keyboard_layout_bulgarian" />
49+
android:keyboardLayout="@raw/keyboard_layout_bulgarian" />
5050

5151
<keyboard-layout android:name="keyboard_layout_italian"
5252
android:label="@string/keyboard_layout_italian"
53-
android:kcm="@raw/keyboard_layout_italian" />
53+
android:keyboardLayout="@raw/keyboard_layout_italian" />
5454

5555
<keyboard-layout android:name="keyboard_layout_danish"
5656
android:label="@string/keyboard_layout_danish"
57-
android:kcm="@raw/keyboard_layout_danish" />
57+
android:keyboardLayout="@raw/keyboard_layout_danish" />
5858

5959
<keyboard-layout android:name="keyboard_layout_norwegian"
6060
android:label="@string/keyboard_layout_norwegian"
61-
android:kcm="@raw/keyboard_layout_norwegian" />
61+
android:keyboardLayout="@raw/keyboard_layout_norwegian" />
6262

6363
<keyboard-layout android:name="keyboard_layout_swedish"
6464
android:label="@string/keyboard_layout_swedish"
65-
android:kcm="@raw/keyboard_layout_swedish" />
65+
android:keyboardLayout="@raw/keyboard_layout_swedish" />
6666

6767
<keyboard-layout android:name="keyboard_layout_finnish"
6868
android:label="@string/keyboard_layout_finnish"
69-
android:kcm="@raw/keyboard_layout_finnish" />
69+
android:keyboardLayout="@raw/keyboard_layout_finnish" />
7070

7171
<keyboard-layout android:name="keyboard_layout_croatian"
7272
android:label="@string/keyboard_layout_croatian"
73-
android:kcm="@raw/keyboard_layout_croatian_and_slovenian" />
73+
android:keyboardLayout="@raw/keyboard_layout_croatian_and_slovenian" />
7474

7575
<keyboard-layout android:name="keyboard_layout_czech"
7676
android:label="@string/keyboard_layout_czech"
77-
android:kcm="@raw/keyboard_layout_czech" />
77+
android:keyboardLayout="@raw/keyboard_layout_czech" />
7878

7979
<keyboard-layout android:name="keyboard_layout_estonian"
8080
android:label="@string/keyboard_layout_estonian"
81-
android:kcm="@raw/keyboard_layout_estonian" />
81+
android:keyboardLayout="@raw/keyboard_layout_estonian" />
8282

8383
<keyboard-layout android:name="keyboard_layout_hungarian"
8484
android:label="@string/keyboard_layout_hungarian"
85-
android:kcm="@raw/keyboard_layout_hungarian" />
85+
android:keyboardLayout="@raw/keyboard_layout_hungarian" />
8686

8787
<keyboard-layout android:name="keyboard_layout_icelandic"
8888
android:label="@string/keyboard_layout_icelandic"
89-
android:kcm="@raw/keyboard_layout_icelandic" />
89+
android:keyboardLayout="@raw/keyboard_layout_icelandic" />
9090

9191
<keyboard-layout android:name="keyboard_layout_portuguese"
9292
android:label="@string/keyboard_layout_portuguese"
93-
android:kcm="@raw/keyboard_layout_portuguese" />
93+
android:keyboardLayout="@raw/keyboard_layout_portuguese" />
9494

9595
<keyboard-layout android:name="keyboard_layout_slovak"
9696
android:label="@string/keyboard_layout_slovak"
97-
android:kcm="@raw/keyboard_layout_slovak" />
97+
android:keyboardLayout="@raw/keyboard_layout_slovak" />
9898

9999
<keyboard-layout android:name="keyboard_layout_slovenian"
100100
android:label="@string/keyboard_layout_slovenian"
101-
android:kcm="@raw/keyboard_layout_croatian_and_slovenian" />
101+
android:keyboardLayout="@raw/keyboard_layout_croatian_and_slovenian" />
102102

103103
<keyboard-layout android:name="keyboard_layout_turkish"
104104
android:label="@string/keyboard_layout_turkish"
105-
android:kcm="@raw/keyboard_layout_turkish" />
105+
android:keyboardLayout="@raw/keyboard_layout_turkish" />
106106

107107
<keyboard-layout android:name="keyboard_layout_ukrainian"
108108
android:label="@string/keyboard_layout_ukrainian"
109-
android:kcm="@raw/keyboard_layout_ukrainian" />
109+
android:keyboardLayout="@raw/keyboard_layout_ukrainian" />
110110
</keyboard-layouts>

services/java/com/android/server/input/InputManagerService.java

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -597,7 +597,7 @@ public KeyboardLayout[] getKeyboardLayouts() {
597597
visitAllKeyboardLayouts(new KeyboardLayoutVisitor() {
598598
@Override
599599
public void visitKeyboardLayout(Resources resources,
600-
String descriptor, String label, int kcmResId) {
600+
String descriptor, String label, int keyboardLayoutResId) {
601601
list.add(new KeyboardLayout(descriptor, label));
602602
}
603603
});
@@ -614,7 +614,7 @@ public KeyboardLayout getKeyboardLayout(String keyboardLayoutDescriptor) {
614614
visitKeyboardLayout(keyboardLayoutDescriptor, new KeyboardLayoutVisitor() {
615615
@Override
616616
public void visitKeyboardLayout(Resources resources,
617-
String descriptor, String label, int kcmResId) {
617+
String descriptor, String label, int keyboardLayoutResId) {
618618
result[0] = new KeyboardLayout(descriptor, label);
619619
}
620620
});
@@ -683,10 +683,11 @@ private void visitKeyboardLayoutsInPackage(PackageManager pm, ActivityInfo recei
683683
com.android.internal.R.styleable.KeyboardLayout_name);
684684
String label = a.getString(
685685
com.android.internal.R.styleable.KeyboardLayout_label);
686-
int kcmResId = a.getResourceId(
687-
com.android.internal.R.styleable.KeyboardLayout_kcm, 0);
688-
if (name == null || label == null || kcmResId == 0) {
689-
Log.w(TAG, "Missing required 'name', 'label' or 'kcm' "
686+
int keyboardLayoutResId = a.getResourceId(
687+
com.android.internal.R.styleable.KeyboardLayout_keyboardLayout,
688+
0);
689+
if (name == null || label == null || keyboardLayoutResId == 0) {
690+
Log.w(TAG, "Missing required 'name', 'label' or 'keyboardLayout' "
690691
+ "attributes in keyboard layout "
691692
+ "resource from receiver "
692693
+ receiver.packageName + "/" + receiver.name);
@@ -695,7 +696,7 @@ private void visitKeyboardLayoutsInPackage(PackageManager pm, ActivityInfo recei
695696
receiver.packageName, receiver.name, name);
696697
if (keyboardName == null || name.equals(keyboardName)) {
697698
visitor.visitKeyboardLayout(resources, descriptor,
698-
label, kcmResId);
699+
label, keyboardLayoutResId);
699700
}
700701
}
701702
} finally {
@@ -1138,11 +1139,11 @@ private String[] getKeyboardLayoutOverlay(String inputDeviceDescriptor) {
11381139
visitKeyboardLayout(keyboardLayoutDescriptor, new KeyboardLayoutVisitor() {
11391140
@Override
11401141
public void visitKeyboardLayout(Resources resources,
1141-
String descriptor, String label, int kcmResId) {
1142+
String descriptor, String label, int keyboardLayoutResId) {
11421143
try {
11431144
result[0] = descriptor;
11441145
result[1] = Streams.readFully(new InputStreamReader(
1145-
resources.openRawResource(kcmResId)));
1146+
resources.openRawResource(keyboardLayoutResId)));
11461147
} catch (IOException ex) {
11471148
} catch (NotFoundException ex) {
11481149
}
@@ -1261,7 +1262,7 @@ public static KeyboardLayoutDescriptor parse(String descriptor) {
12611262

12621263
private interface KeyboardLayoutVisitor {
12631264
void visitKeyboardLayout(Resources resources,
1264-
String descriptor, String label, int kcmResId);
1265+
String descriptor, String label, int keyboardLayoutResId);
12651266
}
12661267

12671268
private final class InputDevicesChangedListenerRecord implements DeathRecipient {

0 commit comments

Comments
 (0)