Skip to content

Commit 2ea1045

Browse files
Romain GuyAndroid (Google) Code Review
authored andcommitted
Merge "Applies a layer's color filter even when the layer is a quad Bug #7238059" into jb-mr1-dev
2 parents fddedc9 + e529ece commit 2ea1045

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

libs/hwui/OpenGLRenderer.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2729,13 +2729,13 @@ status_t OpenGLRenderer::drawLayer(Layer* layer, float x, float y, SkPaint* pain
27292729
mCaches.activeTexture(0);
27302730

27312731
if (CC_LIKELY(!layer->region.isEmpty())) {
2732+
SkiaColorFilter* oldFilter = mColorFilter;
2733+
mColorFilter = layer->getColorFilter();
2734+
27322735
if (layer->region.isRect()) {
27332736
composeLayerRect(layer, layer->regionRect);
27342737
} else if (layer->mesh) {
27352738
const float a = layer->getAlpha() / 255.0f;
2736-
SkiaColorFilter *oldFilter = mColorFilter;
2737-
mColorFilter = layer->getColorFilter();
2738-
27392739
setupDraw();
27402740
setupDrawWithTexture();
27412741
setupDrawColor(a, a, a, a);
@@ -2764,13 +2764,13 @@ status_t OpenGLRenderer::drawLayer(Layer* layer, float x, float y, SkPaint* pain
27642764

27652765
finishDrawTexture();
27662766

2767-
mColorFilter = oldFilter;
2768-
27692767
#if DEBUG_LAYERS_AS_REGIONS
27702768
drawRegionRects(layer->region);
27712769
#endif
27722770
}
27732771

2772+
mColorFilter = oldFilter;
2773+
27742774
if (debugLayerUpdate) {
27752775
drawColorRect(x, y, x + layer->layer.getWidth(), y + layer->layer.getHeight(),
27762776
0x7f00ff00, SkXfermode::kSrcOver_Mode);

0 commit comments

Comments
 (0)