Skip to content

Commit 2e4a560

Browse files
ashish-s-sharmaAndroid (Google) Code Review
authored andcommitted
Merge "Add packet counts to uid and iface stats. Needed to add Ethernet overhead to uid_stats (IP level) to compare with interface stats (Ethernet level)."
2 parents 98c8b52 + baf4c85 commit 2e4a560

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

services/java/com/android/server/EventLogTags.logtags

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,5 +142,5 @@ option java_package com.android.server
142142
# ---------------------------
143143
# NetworkStatsService.java
144144
# ---------------------------
145-
51100 netstats_mobile_sample (iface_rx|2|2),(iface_tx|2|2),(uid_rx|2|2),(uid_tx|2|2)
146-
51101 netstats_wifi_sample (iface_rx|2|2),(iface_tx|2|2),(uid_rx|2|2),(uid_tx|2|2)
145+
51100 netstats_mobile_sample (iface_rx_bytes|2|2),(iface_tx_bytes|2|2),(iface_rx_pkts|2|1),(iface_tx_pkts|2|1),(uid_rx_bytes|2|2),(uid_tx_bytes|2|2),(uid_rx_pkts|2|1),(uid_tx_pkts|2|1)
146+
51101 netstats_wifi_sample (iface_rx_bytes|2|2),(iface_tx_bytes|2|2),(iface_rx_pkts|2|1),(iface_tx_pkts|2|1),(uid_rx_bytes|2|2),(uid_tx_bytes|2|2),(uid_rx_pkts|2|1),(uid_tx_pkts|2|1)

services/java/com/android/server/net/NetworkStatsService.java

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -865,14 +865,20 @@ private void performSample() {
865865
ifaceTotal = getSummaryForNetwork(template, start, end).getTotal(ifaceTotal);
866866
uidTotal = getSummaryForAllUid(template, start, end, false).getTotal(uidTotal);
867867
EventLogTags.writeNetstatsMobileSample(
868-
ifaceTotal.rxBytes, ifaceTotal.txBytes, uidTotal.rxBytes, uidTotal.txBytes);
868+
ifaceTotal.rxBytes, ifaceTotal.txBytes,
869+
ifaceTotal.rxPackets, ifaceTotal.txPackets,
870+
uidTotal.rxBytes, uidTotal.txBytes,
871+
uidTotal.rxPackets, uidTotal.txPackets);
869872

870873
// collect wifi sample
871874
template = buildTemplateWifi();
872875
ifaceTotal = getSummaryForNetwork(template, start, end).getTotal(ifaceTotal);
873876
uidTotal = getSummaryForAllUid(template, start, end, false).getTotal(uidTotal);
874877
EventLogTags.writeNetstatsWifiSample(
875-
ifaceTotal.rxBytes, ifaceTotal.txBytes, uidTotal.rxBytes, uidTotal.txBytes);
878+
ifaceTotal.rxBytes, ifaceTotal.txBytes,
879+
ifaceTotal.rxPackets, ifaceTotal.txPackets,
880+
uidTotal.rxBytes, uidTotal.txBytes,
881+
uidTotal.rxPackets, uidTotal.txPackets);
876882
}
877883

878884
/**

0 commit comments

Comments
 (0)