Skip to content

Commit 28795d8

Browse files
Eino-Ville TalvalaAndroid (Google) Code Review
authored andcommitted
Merge "Fix race condition with preview callback." into jb-dev
2 parents 758534e + ca367b7 commit 28795d8

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

core/java/android/hardware/Camera.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -736,8 +736,8 @@ public void handleMessage(Message msg) {
736736
return;
737737

738738
case CAMERA_MSG_PREVIEW_FRAME:
739-
if (mPreviewCallback != null) {
740-
PreviewCallback cb = mPreviewCallback;
739+
PreviewCallback pCb = mPreviewCallback;
740+
if (pCb != null) {
741741
if (mOneShot) {
742742
// Clear the callback variable before the callback
743743
// in case the app calls setPreviewCallback from
@@ -749,7 +749,7 @@ public void handleMessage(Message msg) {
749749
// Set to oneshot mode again.
750750
setHasPreviewCallback(true, false);
751751
}
752-
cb.onPreviewFrame((byte[])msg.obj, mCamera);
752+
pCb.onPreviewFrame((byte[])msg.obj, mCamera);
753753
}
754754
return;
755755

0 commit comments

Comments
 (0)