Protect against bogus input for ListViews

Guard against cases where ListView might receive touch events while
detached.

Update ListMenuPresenter to dispatch a data set change when the
backing menu is changed.

Bug 6543282

Change-Id: If2fb9b6aa3cf4a1b7070a7cd0de0edf0fc2f4cca

Author: adamp

core/java/android/widget/AbsListView.java

@@ -3351,6 +3351,14 @@ public boolean onTouchEvent(MotionEvent ev) {
             mPositionScroller.stop();
         }
 
+        if (!mIsAttached) {
+            // Something isn't right.
+            // Since we rely on being attached to get data set change notifications,
+            // don't risk doing anything where we might try to resync and find things
+            // in a bogus state.
+            return false;
+        }
+
         if (mFastScroller != null) {
             boolean intercepted = mFastScroller.onTouchEvent(ev);
             if (intercepted) {
@@ -3846,6 +3854,14 @@ public boolean onInterceptTouchEvent(MotionEvent ev) {
             mPositionScroller.stop();
         }
 
+        if (!mIsAttached) {
+            // Something isn't right.
+            // Since we rely on being attached to get data set change notifications,
+            // don't risk doing anything where we might try to resync and find things
+            // in a bogus state.
+            return false;
+        }
+
         if (mFastScroller != null) {
             boolean intercepted = mFastScroller.onInterceptTouchEvent(ev);
             if (intercepted) {

core/java/com/android/internal/view/menu/ListMenuPresenter.java

@@ -88,6 +88,9 @@ public void initForMenu(Context context, MenuBuilder menu) {
             }
         }
         mMenu = menu;
+        if (mAdapter != null) {
+            mAdapter.notifyDataSetChanged();
+        }
     }
 
     @Override