Skip to content

Commit 23d6224

Browse files
Jamie GennisAndroid (Google) Code Review
authored andcommitted
Merge "Set the secureness when creating displays" into jb-mr1-dev
2 parents d07f8d0 + 7bbf816 commit 23d6224

File tree

4 files changed

+10
-8
lines changed

4 files changed

+10
-8
lines changed

core/java/android/view/Surface.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ private static native Bitmap nativeScreenshot(IBinder displayToken,
258258
private native void nativeSetLayerStack(int layerStack);
259259

260260
private static native IBinder nativeGetBuiltInDisplay(int physicalDisplayId);
261-
private static native IBinder nativeCreateDisplay(String name);
261+
private static native IBinder nativeCreateDisplay(String name, boolean secure);
262262
private static native void nativeSetDisplaySurface(
263263
IBinder displayToken, Surface surface);
264264
private static native void nativeSetDisplayLayerStack(
@@ -597,11 +597,11 @@ public static IBinder getBuiltInDisplay(int builtInDisplayId) {
597597
}
598598

599599
/** @hide */
600-
public static IBinder createDisplay(String name) {
600+
public static IBinder createDisplay(String name, boolean secure) {
601601
if (name == null) {
602602
throw new IllegalArgumentException("name must not be null");
603603
}
604-
return nativeCreateDisplay(name);
604+
return nativeCreateDisplay(name, secure);
605605
}
606606

607607
/** @hide */

core/jni/android_view_Surface.cpp

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -653,9 +653,11 @@ static jobject nativeGetBuiltInDisplay(JNIEnv* env, jclass clazz, jint id) {
653653
return javaObjectForIBinder(env, token);
654654
}
655655

656-
static jobject nativeCreateDisplay(JNIEnv* env, jclass clazz, jstring nameObj) {
656+
static jobject nativeCreateDisplay(JNIEnv* env, jclass clazz, jstring nameObj,
657+
jboolean secure) {
657658
ScopedUtfChars name(env, nameObj);
658-
sp<IBinder> token(SurfaceComposerClient::createDisplay(String8(name.c_str())));
659+
sp<IBinder> token(SurfaceComposerClient::createDisplay(
660+
String8(name.c_str()), bool(secure)));
659661
return javaObjectForIBinder(env, token);
660662
}
661663

@@ -845,7 +847,7 @@ static JNINativeMethod gSurfaceMethods[] = {
845847
(void*)nativeSetLayerStack },
846848
{"nativeGetBuiltInDisplay", "(I)Landroid/os/IBinder;",
847849
(void*)nativeGetBuiltInDisplay },
848-
{"nativeCreateDisplay", "(Ljava/lang/String;)Landroid/os/IBinder;",
850+
{"nativeCreateDisplay", "(Ljava/lang/String;Z)Landroid/os/IBinder;",
849851
(void*)nativeCreateDisplay },
850852
{"nativeSetDisplaySurface", "(Landroid/os/IBinder;Landroid/view/Surface;)V",
851853
(void*)nativeSetDisplaySurface },

services/java/com/android/server/display/OverlayDisplayAdapter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ public void dismissLocked() {
282282
@Override
283283
public void onWindowCreated(SurfaceTexture surfaceTexture, float refreshRate) {
284284
synchronized (getSyncRoot()) {
285-
IBinder displayToken = Surface.createDisplay(mName);
285+
IBinder displayToken = Surface.createDisplay(mName, false);
286286
mDevice = new OverlayDisplayDevice(displayToken, mName,
287287
mWidth, mHeight, refreshRate, mDensityDpi, surfaceTexture);
288288

services/java/com/android/server/display/WifiDisplayAdapter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ private void handleConnectLocked(WifiDisplay display,
292292
float refreshRate = 60.0f; // TODO: get this for real
293293

294294
String name = display.getFriendlyDisplayName();
295-
IBinder displayToken = Surface.createDisplay(name);
295+
IBinder displayToken = Surface.createDisplay(name, false);
296296
mDisplayDevice = new WifiDisplayDevice(displayToken, name, width, height,
297297
refreshRate, deviceFlags, surface);
298298
sendDisplayDeviceEventLocked(mDisplayDevice, DISPLAY_DEVICE_EVENT_ADDED);

0 commit comments

Comments
 (0)